[GitHub] [iotdb] wangchao316 commented on a change in pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode

[GitBox <gi...@apache.org>]

wangchao316 commented on a change in pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#discussion_r665905068



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/MergePlan.java
##########
@@ -39,4 +43,17 @@ public MergePlan() {
   public List<PartialPath> getPaths() {
     return Collections.emptyList();
   }
+
+  @Override
+  public void serialize(DataOutputStream stream) throws IOException {
+    stream.writeByte((byte) PhysicalPlanType.MERGE.ordinal());
+  }
+
+  @Override
+  public void serialize(ByteBuffer buffer) {
+    buffer.put((byte) PhysicalPlanType.MERGE.ordinal());
+  }
+
+  @Override
+  public void deserialize(ByteBuffer buffer) throws IllegalPathException {}

Review comment:
       why deserialize do not implementation？ How to deserialize this execution plan?

##########
File path: cluster/src/test/java/org/apache/iotdb/cluster/log/applier/DataLogApplierTest.java
##########
@@ -374,4 +376,20 @@ public void testApplyCreateMultiTimeseiresWithPulling() throws MetadataException
     assertTrue(IoTDB.metaManager.getAllStorageGroupPaths().contains(new PartialPath("root.sg2")));
     assertNull(log.getException());
   }
+

Review comment:
       Good Job.
   
   Generally, the testcontainer needs to be added to implement the functions of the cluster edition.

##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/ClearCachePlan.java
##########
@@ -35,4 +39,17 @@ public ClearCachePlan() {
   public List<PartialPath> getPaths() {
     return Collections.emptyList();
   }
+
+  @Override
+  public void serialize(DataOutputStream stream) throws IOException {
+    stream.writeByte((byte) PhysicalPlanType.CLEARCACHE.ordinal());
+  }
+
+  @Override
+  public void serialize(ByteBuffer buffer) {
+    buffer.put((byte) PhysicalPlanType.CLEARCACHE.ordinal());
+  }
+
+  @Override
+  public void deserialize(ByteBuffer buffer) throws IllegalPathException {}

Review comment:
       why deserialize do not implementation？ How to deserialize this execution plan?

##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/CreateSnapshotPlan.java
##########
@@ -36,4 +40,17 @@ public CreateSnapshotPlan() {
   public List<PartialPath> getPaths() {
     return Collections.emptyList();
   }
+
+  @Override
+  public void serialize(DataOutputStream stream) throws IOException {
+    stream.writeByte((byte) PhysicalPlanType.CREATE_SNAPSHOT.ordinal());
+  }
+
+  @Override
+  public void serialize(ByteBuffer buffer) {
+    buffer.put((byte) PhysicalPlanType.CREATE_SNAPSHOT.ordinal());
+  }
+
+  @Override
+  public void deserialize(ByteBuffer buffer) throws IllegalPathException {}

Review comment:
       why deserialize do not implementation？ How to deserialize this execution plan?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org