You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Fred Cooke (JIRA)" <ji...@codehaus.org> on 2012/12/31 12:09:13 UTC
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Fred Cooke created MRELEASE-814:
-----------------------------------
Summary: Property interpolation of developerConnection broken when inheritting from parent
Key: MRELEASE-814
URL: https://jira.codehaus.org/browse/MRELEASE-814
Project: Maven 2.x Release Plugin
Issue Type: Bug
Components: Git, prepare
Affects Versions: 2.4, 2.3.2, 2.0
Environment: Debian Linux OpenJDK 7 mvn 3.0.4
Reporter: Fred Cooke
Priority: Blocker
Attachments: demo.project.git.release.bug.tgz
If developerConnection is setup like this in a parent and inherited:
<developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
Then the Git SCM URL is incorrect when attempting to do a release:prepare (and perhaps other operations)
In the example project that I've included this is what it tries to do:
[INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
[ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
Note, .ssh/config setup is required for a URL of this nature:
host git
user git
hostname localhost
port 22
identityfile ~/.ssh/id_rsa
Change these, and the deploy details to suit yourself.
I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317239#comment-317239 ]
Robert Scholte commented on MRELEASE-814:
-----------------------------------------
By extending I mean that the folder-path to a module is added to the URL of the connection.
I now remember that for GIT there's always exactly 1 URL, since it is only possible to download the whole repository: there's no way to refer directly to a specific module.
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Critical
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316397#comment-316397 ]
Fred Cooke commented on MRELEASE-814:
-------------------------------------
Having the EXACT same property in the parent and the child project results in success too. I think it should be clear that this is inconsistent/hard-coded behaviour given the fact that the field contents are identical and the results different.
http://maven.apache.org/pom.html#SCM No contact of arbitrary modifications mentioned here.
I guess MVN + Git is still pretty new. :-(
As a temporary workaround I'm going to add the (exact same identical) SCM information to each child POM. I hope I can revert this needless duplication at some point in the not too distant future.
Maven itself seems to be under git now, when are the various plugins scheduled for migration? And/or how does one gain SVN commit access to something like the maven release plugin?
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Blocker
> Attachments: demo.project.git.release.bug.tgz
>
>
> If developerConnection is setup like this in a parent and inherited:
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> Then the Git SCM URL is incorrect when attempting to do a release:prepare (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte updated MRELEASE-814:
------------------------------------
Priority: Critical (was: Blocker)
Lowering to critical, since there's a workaround.
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Critical
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317379#comment-317379 ]
Robert Scholte commented on MRELEASE-814:
-----------------------------------------
With a little less words that was my thought when writing "The only project which could inherit is the executionProject, all modules should extend"
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Critical
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317244#comment-317244 ]
Robert Scholte commented on MRELEASE-814:
-----------------------------------------
Commit by project is supported: [prepare#commitByProject|http://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#commitByProject]
Tag by project is a feature request: MRELEASE-241
I do understand this request, since if you tag a multimodule project, for all modules you need to know the name of the root-project to get to the tagged sources. (And yes I'm talking svn/cvs right now and assuming you're just browsing based on the tags-folder).
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Critical
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317319#comment-317319 ]
Fred Cooke commented on MRELEASE-814:
-------------------------------------
It just occurred to me that this is wrong EVEN for SVN, because the parent is NOT an aggregator, it's JUST a parent. The behaviour would make sense for a default MM project only. If a module was nested 2 dirs deep it would be broken then too. I assume that you must know that you're not a child in an aggregator while you're executing? How about:
"if not child of aggregator, don't mess with path" and also "if parent relative path is set to empty to override default of ../pom.xml, don't mess with path" either of those alone would solve my issue and not depend on hard coding of "if git" or similar.
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Critical
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317133#comment-317133 ]
Fred Cooke commented on MRELEASE-814:
-------------------------------------
What exactly do you mean by "extend"? I don't understand. Usually an MM project tags all at once, right? And uses SCM config from the aggregator, if the release is running from there. Or are you talking about releasing a single module? Does that even make sense/Is that even supported?
Other than that, I'm not sure changing the behaviour in the general case (the assumed SVN case) is a good idea. It will probably break existing SVN users, even fif they are a dying breed. Why not simply check for git and don't do crazy things if git. Maybe mercurial too? Or maybe check for SVN and do crazy things only then? Or some other similar scheme.
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Blocker
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317130#comment-317130 ]
Robert Scholte commented on MRELEASE-814:
-----------------------------------------
I've been thinking about this for a couple of days. The only project which could inherit is the executionProject, all modules should extend. If this breaks tests, we should verify those cases.
IIRC the result of {{help:effective-pom}} is always based on inheritence, which means that the result is wrong for the modules in a multimodule project.
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Blocker
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317380#comment-317380 ]
Fred Cooke commented on MRELEASE-814:
-------------------------------------
OK, so we're on the same page completely, now, then :-)
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Critical
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316397#comment-316397 ]
Fred Cooke edited comment on MRELEASE-814 at 12/31/12 5:48 AM:
---------------------------------------------------------------
Having the EXACT same property in the parent and the child project results in success too. I think it should be clear that this is inconsistent/hard-coded behaviour given the fact that the field contents are identical and the results different.
http://maven.apache.org/pom.html#SCM No contract of arbitrary modifications mentioned here.
I guess MVN + Git is still pretty new. :-(
As a temporary workaround I'm going to add the (exact same identical) SCM information to each child POM. I hope I can revert this needless duplication at some point in the not too distant future.
Maven itself seems to be under git now, when are the various plugins scheduled for migration? And/or how does one gain SVN commit access to something like the maven release plugin?
was (Author: fredcooke):
Having the EXACT same property in the parent and the child project results in success too. I think it should be clear that this is inconsistent/hard-coded behaviour given the fact that the field contents are identical and the results different.
http://maven.apache.org/pom.html#SCM No contact of arbitrary modifications mentioned here.
I guess MVN + Git is still pretty new. :-(
As a temporary workaround I'm going to add the (exact same identical) SCM information to each child POM. I hope I can revert this needless duplication at some point in the not too distant future.
Maven itself seems to be under git now, when are the various plugins scheduled for migration? And/or how does one gain SVN commit access to something like the maven release plugin?
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Blocker
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316401#comment-316401 ]
Robert Scholte commented on MRELEASE-814:
-----------------------------------------
Off topic answers:
{quote}Maven itself seems to be under git now, when are the various plugins scheduled for migration?{quote}
There's no schedule/roadmap for that.
{quote}And/or how does one gain SVN commit access to something like the maven release plugin?{quote}
http://maven.apache.org/guides/development/guide-helping.html#How_do_I_Join_the_Project
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Blocker
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317241#comment-317241 ]
Fred Cooke commented on MRELEASE-814:
-------------------------------------
You could have each module in a git repo (nested within the root one) and need to push to and tag each of them, however I'm unsure if anyone would actually do that. If you were using a pure aggregator (not used as parent) to release the "module" projects, then you could absolutely expect that they have a URL each. It would, however, never have a random path-segment dumped onto it.
Solving this properly probably means an independent per-SCM-provider implementation. And basing each off of a thorough use-case analysis of that SCM system. Solving it quickly and acceptably can be done with a simple fix that won't affect existing users of hierarchicle legacy SCMs such as SVN.
Re my earlier question, does the release plugin commit each module separately? Seems very non-atomic/dangerous/ugly to do so. I'd expect it to be committed from above, and only committed/tagged separately from below if using an override in the module.
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Critical
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-814) Property interpolation of developerConnection
broken when inheritting from parent
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte updated MRELEASE-814:
------------------------------------
Description:
If {{developerConnection}} is setup like this in a parent and inherited:
{code:xml}
<developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
{code}
Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
In the example project that I've included this is what it tries to do:
{noformat}
[INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
[ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
{noformat}
I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
Note, .ssh/config setup is required for a URL of this nature:
{noformat}
host git
user git
hostname localhost
port 22
identityfile ~/.ssh/id_rsa
{noformat}
Change these, and the deploy details to suit yourself.
I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
was:
If developerConnection is setup like this in a parent and inherited:
<developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
Then the Git SCM URL is incorrect when attempting to do a release:prepare (and perhaps other operations)
In the example project that I've included this is what it tries to do:
[INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
[ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
Note, .ssh/config setup is required for a URL of this nature:
host git
user git
hostname localhost
port 22
identityfile ~/.ssh/id_rsa
Change these, and the deploy details to suit yourself.
I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
> Property interpolation of developerConnection broken when inheritting from parent
> ---------------------------------------------------------------------------------
>
> Key: MRELEASE-814
> URL: https://jira.codehaus.org/browse/MRELEASE-814
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: Git, prepare
> Affects Versions: 2.0, 2.3.2, 2.4
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Priority: Blocker
> Attachments: demo.project.git.release.bug.tgz
>
>
> If {{developerConnection}} is setup like this in a parent and inherited:
> {code:xml}
> <developerConnection>scm:git:git:${project.groupId}/${project.artifactId}.git</developerConnection>
> {code}
> Then the Git SCM URL is incorrect when attempting to do a {{release:prepare}} (and perhaps other operations)
> In the example project that I've included this is what it tries to do:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /home/fred/workspace/ShouldSeeThisOnceOnly && git push git:com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly master:master
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project ShouldSeeThisOnceOnly: Unable to commit files
> [ERROR] W access for com.example/ShouldSeeThisOnceOnly.git/ShouldSeeThisOnceOnly DENIED to fred
> {noformat}
> I've used this same method with the property directly in the project POM with success. It seems that having it in the parent is the issue.
> Note, .ssh/config setup is required for a URL of this nature:
> {noformat}
> host git
> user git
> hostname localhost
> port 22
> identityfile ~/.ssh/id_rsa
> {noformat}
> Change these, and the deploy details to suit yourself.
> I sincerely hope that I'm doing something stupid and that this is not a bug as I desperately need to do some releases and waiting for a fix wouldn't be ideal, nor would hacking what should be inherited into each POM. Sadly, I doubt that I'm wrong this time, as I copy pasted the exact contents from my bogus parent into my pom, removed the parent ref, and it works as expected. This seems like an ugly hangover from SVN usage to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira