You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/11/19 02:05:18 UTC
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14741
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
IMPALA-9165: Add timeout for create-load-data.sh
This converts the existing bin/run-all-tests-timeout-check.sh
to a more generic bin/script-timeout-check.sh. It uses this
new script for both bin/run-all-tests.sh and
testdata/bin/create-load-data.sh. The run-all-tests.sh timeout
remains the same. testdata/bin/create-load-data.sh uses a
2.5 hour timeout. This should help debug the issue in
IMPALA-9165, because at least the logs would be preserved
on the Jenkins job.
Testing:
- Running a gerrit-verify-dryrun-external
Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
---
M bin/run-all-tests.sh
R bin/script-timeout-check.sh
M testdata/bin/create-load-data.sh
3 files changed, 31 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/14741/1
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5253/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 04:44:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5071/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 20:23:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5255/
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 21:33:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 1:
(2 comments)
Made some changes to the script's argument parsing to add a script_name to use in debugging messages / filenames.
http://gerrit.cloudera.org:8080/#/c/14741/1/bin/script-timeout-check.sh
File bin/script-timeout-check.sh:
http://gerrit.cloudera.org:8080/#/c/14741/1/bin/script-timeout-check.sh@74
PS1, Line 74: --step "test_run"
> does this parameter, or the --phase parameter need to be changed depending
Good point, added a script_name argument to this script so that we can have better messages / filenames.
http://gerrit.cloudera.org:8080/#/c/14741/1/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:
http://gerrit.cloudera.org:8080/#/c/14741/1/testdata/bin/create-load-data.sh@106
PS1, Line 106: minute
> nit: minutes
Done
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 20:07:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5255/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 17:02:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5058/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 02:19:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14741/1/bin/script-timeout-check.sh
File bin/script-timeout-check.sh:
http://gerrit.cloudera.org:8080/#/c/14741/1/bin/script-timeout-check.sh@74
PS1, Line 74: --step "test_run"
does this parameter, or the --phase parameter need to be changed depending on if this is calling during test execution vs. data load?
http://gerrit.cloudera.org:8080/#/c/14741/1/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:
http://gerrit.cloudera.org:8080/#/c/14741/1/testdata/bin/create-load-data.sh@106
PS1, Line 106: minute
nit: minutes
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 16:24:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 3: Verified+1
There is one test failure on the dockerised tests in TestTpchQuery.test_tpch table_format: kudu/none-TPC-H: Q18 hitting a mem limit. This is unrelated to this change (I found a similar occurrence on master), and this code change is important. Overriding to get this in.
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 21:59:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 3: Code-Review+2
Rebased, carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 17:02:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Sahil Takiar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14741
to look at the new patch set (#3).
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
IMPALA-9165: Add timeout for create-load-data.sh
This converts the existing bin/run-all-tests-timeout-check.sh
to a more generic bin/script-timeout-check.sh. It uses this
new script for both bin/run-all-tests.sh and
testdata/bin/create-load-data.sh. The new script takes two
arguments:
-timeout : timeout in minutes
-script_name : name of the calling script
The script_name is used in debugging output / output filenames
to make it clear what timed out.
The run-all-tests.sh timeout remains the same.
testdata/bin/create-load-data.sh uses a 2.5 hour timeout.
This should help debug the issue in IMPALA-9165, because at
least the logs would be preserved on the Jenkins job.
Testing:
- Tested the timeout script by hand with a caller script that
sleeps longer than the timeout
- Ran a gerrit-verify-dryrun-external
Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
---
D bin/run-all-tests-timeout-check.sh
M bin/run-all-tests.sh
A bin/script-timeout-check.sh
M testdata/bin/create-load-data.sh
4 files changed, 129 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/14741/3
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
IMPALA-9165: Add timeout for create-load-data.sh
This converts the existing bin/run-all-tests-timeout-check.sh
to a more generic bin/script-timeout-check.sh. It uses this
new script for both bin/run-all-tests.sh and
testdata/bin/create-load-data.sh. The new script takes two
arguments:
-timeout : timeout in minutes
-script_name : name of the calling script
The script_name is used in debugging output / output filenames
to make it clear what timed out.
The run-all-tests.sh timeout remains the same.
testdata/bin/create-load-data.sh uses a 2.5 hour timeout.
This should help debug the issue in IMPALA-9165, because at
least the logs would be preserved on the Jenkins job.
Testing:
- Tested the timeout script by hand with a caller script that
sleeps longer than the timeout
- Ran a gerrit-verify-dryrun-external
Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Reviewed-on: http://gerrit.cloudera.org:8080/14741
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
D bin/run-all-tests-timeout-check.sh
M bin/run-all-tests.sh
A bin/script-timeout-check.sh
M testdata/bin/create-load-data.sh
4 files changed, 129 insertions(+), 71 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14741/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/14741/2/bin/run-all-tests.sh@125
PS2, Line 125: "run-all-tests.sh
> "$0"?
Set to "$(basename $0)" to get rid of the directories
http://gerrit.cloudera.org:8080/#/c/14741/2/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:
http://gerrit.cloudera.org:8080/#/c/14741/2/testdata/bin/create-load-data.sh@118
PS2, Line 118: create-load-data.sh
> "$0"?
Set to "$(basename $0)" to get rid of the directories
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 17:01:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14741/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/14741/2/bin/run-all-tests.sh@125
PS2, Line 125: "run-all-tests.sh
"$0"?
http://gerrit.cloudera.org:8080/#/c/14741/2/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:
http://gerrit.cloudera.org:8080/#/c/14741/2/testdata/bin/create-load-data.sh@118
PS2, Line 118: create-load-data.sh
"$0"?
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 22:41:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5251/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 20:09:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 2:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5253/
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 09:21:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 16:44:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Sahil Takiar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14741
to look at the new patch set (#2).
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
IMPALA-9165: Add timeout for create-load-data.sh
This converts the existing bin/run-all-tests-timeout-check.sh
to a more generic bin/script-timeout-check.sh. It uses this
new script for both bin/run-all-tests.sh and
testdata/bin/create-load-data.sh. The new script takes two
arguments:
-timeout : timeout in minutes
-script_name : name of the calling script
The script_name is used in debugging output / output filenames
to make it clear what timed out.
The run-all-tests.sh timeout remains the same.
testdata/bin/create-load-data.sh uses a 2.5 hour timeout.
This should help debug the issue in IMPALA-9165, because at
least the logs would be preserved on the Jenkins job.
Testing:
- Tested the timeout script by hand with a caller script that
sleeps longer than the timeout
- Ran a gerrit-verify-dryrun-external
Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
---
D bin/run-all-tests-timeout-check.sh
M bin/run-all-tests.sh
A bin/script-timeout-check.sh
M testdata/bin/create-load-data.sh
4 files changed, 129 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/14741/2
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5251/
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 01:30:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5243/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 02:06:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 06:53:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5086/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 17:45:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has removed a vote on this change.
Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>