[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1618: before delete Udf check exist

[GitBox <gi...@apache.org>]

Technoboy- commented on a change in pull request #1618: before delete Udf check exist
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1618#discussion_r361790999
 
 

 ##########
 File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UdfFuncService.java
 ##########
 @@ -303,7 +303,12 @@ private boolean checkUdfFuncNameExists(String name){
     @Transactional(rollbackFor = Exception.class)
     public Result delete(int id) {
         Result result = new Result();
-
+        //check exist
 
 Review comment:
   What is the benefit of the checking logic before deleting ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services