You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Daan Hoogland <da...@gmail.com> on 2015/07/07 11:47:34 UTC
Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2
Rohit, are you basing this on 4.5? seems like a feature (meaning it
should be based on master).
On Tue, Jul 7, 2015 at 11:42 AM, <bh...@apache.org> wrote:
> Repository: cloudstack
> Updated Branches:
> refs/heads/4.5-ui-plugin-enhancement [created] f8693d24a
>
>
> ui: Allow UI plugins to be shown on navigation bar
>
> Introduces a boolean option in UI plugins setting it to 'true' would display
> the UI plugin on the left navigation bar.
>
> Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
>
>
> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
> Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f8693d24
> Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f8693d24
> Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f8693d24
>
> Branch: refs/heads/4.5-ui-plugin-enhancement
> Commit: f8693d24a42dc806c67a4b12731b0ea20f6bd791
> Parents: 7eac631
> Author: Rohit Yadav <ro...@shapeblue.com>
> Authored: Tue Jul 7 15:01:12 2015 +0530
> Committer: Rohit Yadav <ro...@shapeblue.com>
> Committed: Tue Jul 7 15:11:45 2015 +0530
>
> ----------------------------------------------------------------------
> ui/plugins/testPlugin/testPlugin.js | 1 +
> ui/scripts/cloudStack.js | 13 ++++++++++++-
> ui/scripts/ui/core.js | 4 ++--
> 3 files changed, 15 insertions(+), 3 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f8693d24/ui/plugins/testPlugin/testPlugin.js
> ----------------------------------------------------------------------
> diff --git a/ui/plugins/testPlugin/testPlugin.js b/ui/plugins/testPlugin/testPlugin.js
> index e340ae5..66ce56f 100644
> --- a/ui/plugins/testPlugin/testPlugin.js
> +++ b/ui/plugins/testPlugin/testPlugin.js
> @@ -19,6 +19,7 @@
> plugin.ui.addSection({
> id: 'testPlugin',
> title: 'TestPlugin',
> + showOnNavigation: true,
> preFilter: function(args) {
> return isAdmin();
> },
>
> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f8693d24/ui/scripts/cloudStack.js
> ----------------------------------------------------------------------
> diff --git a/ui/scripts/cloudStack.js b/ui/scripts/cloudStack.js
> index a701c41..67ec1d5 100644
> --- a/ui/scripts/cloudStack.js
> +++ b/ui/scripts/cloudStack.js
> @@ -32,7 +32,18 @@
> }
>
> if (cloudStack.plugins.length) {
> - sections.push('plugins');
> + var displayPluginSection = false;
> + $.each(cloudStack.plugins, function(idx, plugin) {
> + if (cloudStack.sections.hasOwnProperty(plugin)) {
> + if (!cloudStack.sections[plugin].showOnNavigation) {
> + displayPluginSection = true;
> + return false;
> + }
> + }
> + });
> + if (displayPluginSection) {
> + sections.push('plugins');
> + }
> }
>
> return sections;
>
> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f8693d24/ui/scripts/ui/core.js
> ----------------------------------------------------------------------
> diff --git a/ui/scripts/ui/core.js b/ui/scripts/ui/core.js
> index 6912d1b..e64f386 100644
> --- a/ui/scripts/ui/core.js
> +++ b/ui/scripts/ui/core.js
> @@ -61,7 +61,7 @@
> );
> }
>
> - if (args.isPlugin) {
> + if (args.isPlugin && !args.showOnNavigation) {
> $li.hide();
> }
>
> @@ -88,7 +88,7 @@
> return $(this).hasClass(sectionID);
> });
> var data = args.sections[sectionID];
> - var isPlugin = data.isPlugin;
> + var isPlugin = data.isPlugin && !data.showOnNavigation;
>
> data.$browser = $browser;
>
>
--
Daan
Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2
Posted by Daan Hoogland <da...@gmail.com>.
On Tue, Jul 7, 2015 at 12:16 PM, Rohit Yadav <ro...@shapeblue.com>
wrote:
> Depends - I would want this. One could say it’s a bug that UI plugins are
> listed but hidden (see the code, a <li> is added, but if the section is a
> plugin it hides it by setting display:none).
>
I can go for that :)
>
> Quick question - if a new feature, refactoring work or enhancement is
> sent for master, will they be blocked to be merged on master, until 4.6 is
> released even if they get 2 positive reviews? What is the freeze date for
> 4.6 and who’s the RM?
>
I don't think we covered this case in our recent agreements. I would
propose to handle this on a feature by feature case during freeze. Outside
of freeze 2 LTGM should always suffice.
--
Daan
Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to
f8693d2
Posted by Rohit Yadav <ro...@shapeblue.com>.
Depends - I would want this. One could say it’s a bug that UI plugins are listed but hidden (see the code, a <li> is added, but if the section is a plugin it hides it by setting display:none).
Quick question - if a new feature, refactoring work or enhancement is sent for master, will they be blocked to be merged on master, until 4.6 is released even if they get 2 positive reviews? What is the freeze date for 4.6 and who’s the RM?
On 07-Jul-2015, at 3:38 pm, Daan Hoogland <da...@gmail.com>> wrote:
ok, but we should not wait with a release for this or wait releasing 4.6?
On Tue, Jul 7, 2015 at 12:02 PM, Rohit Yadav <ro...@shapeblue.com>>
wrote:
On 07-Jul-2015, at 3:17 pm, Daan Hoogland <da...@gmail.com> wrote:
Rohit, are you basing this on 4.5? seems like a feature (meaning it
should be based on master).
Not a feature but refactoring - I want to show any UI plugin on left nav
without forking the core code which is done historically, see this —
http://www.slideshare.net/cloudstack/cloudstack-ui-customization (slide
#13).
Since 4.5 is stable, I tend to work on 4.5 based branches and then
port/merge them on master. Yeah, this needs to go into master though useful
for 4.5 as well.
Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +91 88 262 30892 | rohit.yadav@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab
Find out more about ShapeBlue and our range of CloudStack related
services
IaaS Cloud Design & Build
<http://shapeblue.com/iaas-cloud-design-and-build//>
CSForge – rapid IaaS deployment framework <http://shapeblue.com/csforge/>
CloudStack Consulting <http://shapeblue.com/cloudstack-consultancy/>
CloudStack Software Engineering
<http://shapeblue.com/cloudstack-software-engineering/>
CloudStack Infrastructure Support
<http://shapeblue.com/cloudstack-infrastructure-support/>
CloudStack Bootcamp Training Courses
<http://shapeblue.com/cloudstack-training/>
This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any views or
opinions expressed are solely those of the author and do not necessarily
represent those of Shape Blue Ltd or related companies. If you are not the
intended recipient of this email, you must neither take any action based
upon its contents, nor copy or show it to anyone. Please contact the sender
if you believe you have received this email in error. Shape Blue Ltd is a
company incorporated in England & Wales. ShapeBlue Services India LLP is a
company incorporated in India and is operated under license from Shape Blue
Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
a company registered by The Republic of South Africa and is traded under
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
--
Daan
Regards,
Rohit Yadav
Software Architect, ShapeBlue
[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]
M. +91 88 262 30892 | rohit.yadav@shapeblue.com<ma...@shapeblue.com>
Blog: bhaisaab.org<http://bhaisaab.org> | Twitter: @_bhaisaab
Find out more about ShapeBlue and our range of CloudStack related services
IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//>
CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/>
CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/>
CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/>
This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2
Posted by Daan Hoogland <da...@gmail.com>.
ok, but we should not wait with a release for this or wait releasing 4.6?
On Tue, Jul 7, 2015 at 12:02 PM, Rohit Yadav <ro...@shapeblue.com>
wrote:
>
> On 07-Jul-2015, at 3:17 pm, Daan Hoogland <da...@gmail.com> wrote:
>
> Rohit, are you basing this on 4.5? seems like a feature (meaning it
> should be based on master).
>
>
> Not a feature but refactoring - I want to show any UI plugin on left nav
> without forking the core code which is done historically, see this —
> http://www.slideshare.net/cloudstack/cloudstack-ui-customization (slide
> #13).
>
> Since 4.5 is stable, I tend to work on 4.5 based branches and then
> port/merge them on master. Yeah, this needs to go into master though useful
> for 4.5 as well.
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
>
>
>
>
> M. +91 88 262 30892 | rohit.yadav@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related
> services
>
> IaaS Cloud Design & Build
> <http://shapeblue.com/iaas-cloud-design-and-build//>
> CSForge – rapid IaaS deployment framework <http://shapeblue.com/csforge/>
> CloudStack Consulting <http://shapeblue.com/cloudstack-consultancy/>
> CloudStack Software Engineering
> <http://shapeblue.com/cloudstack-software-engineering/>
> CloudStack Infrastructure Support
> <http://shapeblue.com/cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses
> <http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>
--
Daan
Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to
f8693d2
Posted by Rohit Yadav <ro...@shapeblue.com>.
On 07-Jul-2015, at 3:17 pm, Daan Hoogland <da...@gmail.com>> wrote:
Rohit, are you basing this on 4.5? seems like a feature (meaning it
should be based on master).
Not a feature but refactoring - I want to show any UI plugin on left nav without forking the core code which is done historically, see this — http://www.slideshare.net/cloudstack/cloudstack-ui-customization (slide #13).
Since 4.5 is stable, I tend to work on 4.5 based branches and then port/merge them on master. Yeah, this needs to go into master though useful for 4.5 as well.
Regards,
Rohit Yadav
Software Architect, ShapeBlue
[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]
M. +91 88 262 30892 | rohit.yadav@shapeblue.com<ma...@shapeblue.com>
Blog: bhaisaab.org<http://bhaisaab.org> | Twitter: @_bhaisaab
Find out more about ShapeBlue and our range of CloudStack related services
IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//>
CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/>
CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/>
CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/>
This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.