[jira] [Commented] (HBASE-23683) Make HBaseInterClusterReplicationEndpoint more extensible

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017350#comment-17017350 ] 

Hudson commented on HBASE-23683:
--------------------------------

Results for branch master
	[build #1599 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1599/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Make HBaseInterClusterReplicationEndpoint more extensible
> ---------------------------------------------------------
>
>                 Key: HBASE-23683
>                 URL: https://issues.apache.org/jira/browse/HBASE-23683
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Major
>             Fix For: 3.0.0
>
>
> *HBaseInterClusterReplicationEndpoint* currently creates the cluster connection and sink manager instances inside its _init_ method and assigns those to private class variables. Then any potential custom extension of *HBaseInterClusterReplicationEndpoint* that requires custom implementations of connection and/or sink manager would need to resort to _java reflection_ for effectively replace those instances, such as below:
> {noformat}
> ...
>     ClusterConnection conn = (ClusterConnection)ConnectionFactory.
>       createConnection(context.getConfiguration(), User.create(replicationUgi));
>     ReplicationSinkManager sinkManager = new ReplicationSinkManager(conn, ctx.getPeerId(),
>       this, context.getConfiguration());
>     try {
>       Field field = this.getClass().getSuperclass().getDeclaredField("conn");
>       field.setAccessible(true);
>       field.set(this, conn);
>       field = this.getClass().getSuperclass().getDeclaredField("replicationSinkMgr");
>       field.setAccessible(true);
>       field.set(this, sinkManager);
>     } catch (Exception e) {
>       throw new IOException(e);
>     }
> ...
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)