You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/13 14:36:55 UTC
[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8733:
[FLINK-12835][tests] Fix wrong conversion of ManualClock bug
eaglewatcherwb commented on a change in pull request #8733: [FLINK-12835][tests] Fix wrong conversion of ManualClock bug
URL: https://github.com/apache/flink/pull/8733#discussion_r293413590
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolTest.java
##########
@@ -587,7 +587,7 @@ public void testCheckIdleSlot() throws Exception {
assertThat(slotPool.offerSlot(taskManagerLocation, taskManagerGateway, slotToNotExpire),
Matchers.is(true));
- clock.advanceTime(1L, TimeUnit.MILLISECONDS);
+ clock.advanceTime(2L, TimeUnit.MILLISECONDS);
Review comment:
Idle condition is `currentRelativeTimeMillis - slotAndTimestamp.timestamp > idleSlotTimeout.toMilliseconds()`, thus clock should advance `timeout.toMilliseconds() + 1` to trigger idle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services