You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by "mawiesne (via GitHub)" <gi...@apache.org> on 2023/01/23 16:41:41 UTC

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #72: Update sandbox component 'wikinews-importer' to be compatible with latest opennlp-tools release

mawiesne commented on code in PR #72:
URL: https://github.com/apache/opennlp-sandbox/pull/72#discussion_r1084291675


##########
wikinews-importer/src/main/java/org/apache/opennlp/wikinews_importer/AnnotatingMarkupParser.java:
##########
@@ -91,24 +87,21 @@ public AnnotatingMarkupParser(String languageCode) {
         model = makeWikiModel(languageCode);
     }
 
-    public WikiModel makeWikiModel(String languageCode) {
-        return new WikiModel(String.format(
-                "http:/%s.wikipedia.org/wiki/${image}", languageCode),
-                String.format("http://%s.wikipedia.org/wiki/${title}",
-                        languageCode)) {
+    public WikiModel makeWikiModel(String langCode) {
+        return new WikiModel(String.format("https:/%s.wikipedia.org/wiki/${image}", langCode),
+                String.format("https://%s.wikipedia.org/wiki/${title}", langCode)) {
             @Override
             public String getRawWikiContent(String namespace,
                     String articleName, Map<String, String> templateParameters) {
                 // disable template support
-                // TODO: we need to readd template support at least for dates
+                // TODO: we need to read template support at least for dates

Review Comment:
   Correct. Will fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org