[jira] [Commented] (CAMEL-7220) Camel Schematron component

["Bilgin Ibryam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076773#comment-14076773 ] 

Bilgin Ibryam commented on CAMEL-7220:
--------------------------------------

Dear Ayache, 

this is a great contribution. Can you do the following cleanup pls:

1. run mvn clean install -Pfastinstall,sourcecheck for your component and fix the warnings.
2. Add license header to camel-schematron/src/main/resources/META-INF/services/org/apache/camel/component/schematron file. Also to all the files, including test resources.
3. Update component pom to use only one version of Camel
4. Remove author refs in the source files
5. Rename contants package to constants
6. Do you really need saxon-dom? can you remove that dependency and replace net.sf.saxon.FeatureKeys with net.sf.saxon.lib.FeatureKeys? With that change tests seem to pass fine.
7. Can you provide a link to where you get the copy of all the resources in camel-schematron/src/main/resources/iso-schematron-xslt2 folder, so we can verify their license. 
8. Change the constant values so they are consistent with other components, ie start with CamelSchematron

Thanks,

> Camel Schematron component
> --------------------------
>
>                 Key: CAMEL-7220
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7220
>             Project: Camel
>          Issue Type: New Feature
>            Reporter: ayache khettar
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>
> Hi
> I would like to contribute apache camel components by introducing the schematron engine. Here is a link to it in Github: https://github.com/akhettar/camel/tree/master/components/camel-schematron
> Comments and suggestions are welcome.
> Regards,
> Ayache



--
This message was sent by Atlassian JIRA
(v6.2#6252)