You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/07 11:41:54 UTC
[GitHub] [pulsar] codelipenghui commented on a change in pull request #7968: [Issue 7759] Support set Max Consumer on topic level.
codelipenghui commented on a change in pull request #7968:
URL: https://github.com/apache/pulsar/pull/7968#discussion_r484378934
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
##########
@@ -153,6 +153,9 @@ public CmdTopics(PulsarAdmin admin) {
jcommander.addCommand("get-inactive-topic-policies", new GetInactiveTopicPolicies());
jcommander.addCommand("set-inactive-topic-policies", new SetInactiveTopicPolicies());
jcommander.addCommand("remove-inactive-topic-policies", new RemoveInactiveTopicPolicies());
+ jcommander.addCommand("get-maxConsumers", new GetMaxConsumers());
+ jcommander.addCommand("set-maxConsumers", new SetMaxConsumers());
+ jcommander.addCommand("remove-maxConsumers", new RemoveMaxConsumers());
Review comment:
And please also update the max producers as the above pattern.
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
##########
@@ -153,6 +153,9 @@ public CmdTopics(PulsarAdmin admin) {
jcommander.addCommand("get-inactive-topic-policies", new GetInactiveTopicPolicies());
jcommander.addCommand("set-inactive-topic-policies", new SetInactiveTopicPolicies());
jcommander.addCommand("remove-inactive-topic-policies", new RemoveInactiveTopicPolicies());
+ jcommander.addCommand("get-maxConsumers", new GetMaxConsumers());
+ jcommander.addCommand("set-maxConsumers", new SetMaxConsumers());
+ jcommander.addCommand("remove-maxConsumers", new RemoveMaxConsumers());
Review comment:
```suggestion
jcommander.addCommand("get-max-consumers", new GetMaxConsumers());
jcommander.addCommand("set-max-consumers", new SetMaxConsumers());
jcommander.addCommand("remove-max-consumers", new RemoveMaxConsumers());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org