You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/17 22:30:02 UTC
[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #3567: ARTEMIS-3283 Added SlowConsumerThreshold unit configuration option
michaelpearce-gain commented on a change in pull request #3567:
URL: https://github.com/apache/activemq-artemis/pull/3567#discussion_r633907940
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -3638,12 +3638,29 @@
<xsd:element name="slow-consumer-threshold" type="xsd:long" maxOccurs="1" minOccurs="0">
<xsd:annotation>
<xsd:documentation>
- The minimum rate of message consumption allowed before a consumer is considered "slow." Measured
- in messages-per-second.
+ The minimum rate of message consumption allowed before a consumer is considered "slow." Measurement
+ unit is defined by the slow-consumer-threshold-measurement-unit parameter. By default this is
+ messages-per-seconds
</xsd:documentation>
</xsd:annotation>
</xsd:element>
+ <xsd:element name="slow-consumer-threshold-measurement-unit" maxOccurs="1" minOccurs="0">
+ <xsd:annotation>
+ <xsd:documentation>
+ The units used to measure the slow consumer threshold. Default is messages-per-second.
+ </xsd:documentation>
+ </xsd:annotation>
+ <xsd:simpleType>
+ <xsd:restriction base="xsd:string">
Review comment:
@clebertsuconic / @mtaylor this looks very similar to the period unit that is in the journal history, i assume we're just using TimeUnit under the covers, should we maybe extract the type and simply share it....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org