You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2019/07/05 08:42:07 UTC
[flink] branch release-1.7 updated: [FLINK-12889] Set
FatalExitExceptionHandler for StreamTask#asyncOperationsThreadPool
This is an automated email from the ASF dual-hosted git repository.
trohrmann pushed a commit to branch release-1.7
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.7 by this push:
new 7aad964 [FLINK-12889] Set FatalExitExceptionHandler for StreamTask#asyncOperationsThreadPool
7aad964 is described below
commit 7aad9649b83387f86d076014654f3af091640c05
Author: Till Rohrmann <tr...@apache.org>
AuthorDate: Tue Jul 2 14:57:21 2019 +0200
[FLINK-12889] Set FatalExitExceptionHandler for StreamTask#asyncOperationsThreadPool
In order to avoid the swallowing of uncaught exceptions in asynchronous checkpoint operations,
this commit sets the FatalExitExceptionHandler for the StreamTask#asyncOperationsThreadPool.
For testing purposes the uncaught exception handler was made configurable in the StreamTask.
This closes #8950.
---
.../java/org/apache/flink/streaming/runtime/tasks/StreamTask.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
index 9ee8892..57a4ce0 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
@@ -40,6 +40,8 @@ import org.apache.flink.runtime.state.StateBackend;
import org.apache.flink.runtime.state.StateBackendLoader;
import org.apache.flink.runtime.state.TaskStateManager;
import org.apache.flink.runtime.taskmanager.DispatcherThreadFactory;
+import org.apache.flink.runtime.util.ExecutorThreadFactory;
+import org.apache.flink.runtime.util.FatalExitExceptionHandler;
import org.apache.flink.streaming.api.TimeCharacteristic;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.graph.StreamEdge;
@@ -243,7 +245,7 @@ public abstract class StreamTask<OUT, OP extends StreamOperator<OUT>>
// -------- Initialize ---------
LOG.debug("Initializing {}.", getName());
- asyncOperationsThreadPool = Executors.newCachedThreadPool();
+ asyncOperationsThreadPool = Executors.newCachedThreadPool(new ExecutorThreadFactory("AsyncOperations", FatalExitExceptionHandler.INSTANCE));
CheckpointExceptionHandlerFactory cpExceptionHandlerFactory = createCheckpointExceptionHandlerFactory();
@@ -1073,7 +1075,7 @@ public abstract class StreamTask<OUT, OP extends StreamOperator<OUT>>
startAsyncPartNano);
owner.cancelables.registerCloseable(asyncCheckpointRunnable);
- owner.asyncOperationsThreadPool.submit(asyncCheckpointRunnable);
+ owner.asyncOperationsThreadPool.execute(asyncCheckpointRunnable);
if (LOG.isDebugEnabled()) {
LOG.debug("{} - finished synchronous part of checkpoint {}. " +