You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by blrunner <gi...@git.apache.org> on 2015/09/05 18:20:29 UTC

[GitHub] tajo pull request: TAJO-1727: Unable to create external table on H...

GitHub user blrunner opened a pull request:

    https://github.com/apache/tajo/pull/732

    TAJO-1727: Unable to create external table on HBaseTableSpace

    When creating external table, add setting tablespace.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/blrunner/tajo TAJO-1727

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #732
    
----
commit 2747af99be91d1c9b5502fcee4cbab18f00ee460
Author: JaeHwa Jung <bl...@apache.org>
Date:   2015-09-05T16:17:34Z

    TAJO-1727: Unable to create external table on HBaseTableSpace

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Avoid to create external table using...

Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-139266237
  
    +1 looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Allow to create external table with ...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-138921890
  
    I agree with Jihoon's comment. The title may be matter. For unit tests, I'm going to add some unit tests after I improve the exception system with the better error message. So, it can be skip if you guys agree with my plan.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Avoid to create external table using...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-139104768
  
    I updated the title and added unit test cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Allow to create external table with ...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/732#discussion_r39023306
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java ---
    @@ -1285,6 +1285,10 @@ public Expr visitCreate_table_statement(Create_table_statementContext ctx) {
         if (checkIfExist(ctx.EXTERNAL())) {
           createTable.setExternal();
     
    +      if (checkIfExist(ctx.TABLESPACE())) {
    +        throw new TajoRuntimeException(new SQLSyntaxError("CREATE EXTERNAL TABLE cannot be used with tablespace"));
    --- End diff --
    
    It would be better if Tablespace clause is a subject. So, I'd like to recommend ``Tablespace clause is not allowed for an external table``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Allow to create external table with ...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/732#discussion_r39023547
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java ---
    @@ -1293,6 +1297,9 @@ public Expr visitCreate_table_statement(Create_table_statementContext ctx) {
           if (checkIfExist(ctx.LOCATION())) {
             String uri = stripQuote(ctx.uri.getText());
             createTable.setLocation(uri);
    +      } else {
    +        throw new TajoRuntimeException(new SQLSyntaxError("EXTERNAL and LOCATION clauses need to be specified " +
    --- End diff --
    
    How about ``LOCATION clause must be required for an external table.``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Allow to create external table with ...

Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-138917645
  
    Please hold on a second.
    This patch lacks any test. Would you add it?
    In addition, the issue title is mismatched with the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Allow to create external table with ...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-138855963
  
    +1
    
    The patch looks good to me. It's right validation. If you agree with my comments, you can commit it after you reflect my comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Avoid to create external table using...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-139088521
  
    Thanks guys. I also think that the tile is mismatched.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Avoid to create external table using...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/732


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Avoid to create external table using...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-139236887
  
    Thanks @jihoonson 
    
    I've reflected your comments and rebased. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Avoid to create external table using...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-139382323
  
    Thanks @jihoonson 
    
    I'll ship it. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Allow to create external table with ...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-138421605
  
    External table must requires a location URL. So, it does not need a tablespace clause.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1727: Allow to create external table with ...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/732#issuecomment-138449284
  
    Thanks @hyunsik .
    I've just updated the patch using your comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---