You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 06:46:00 UTC
[GitHub] [airflow] pragyak412 opened a new pull request #21451: TrinoHook add authentication via JWT token and Impersonation #19008
pragyak412 opened a new pull request #21451:
URL: https://github.com/apache/airflow/pull/21451
Resolves: https://github.com/apache/airflow/issues/18969
This change introduces the authentication method via JWT and also the possibility to impersonate as DAG owner.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #21451: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #21451:
URL: https://github.com/apache/airflow/pull/21451#issuecomment-1055114539
Can you please fix static checks?
https://github.com/apache/airflow/blob/main/BREEZE.rst#running-static-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #21451: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #21451:
URL: https://github.com/apache/airflow/pull/21451#discussion_r810857012
##########
File path: airflow/providers/trino/hooks/trino.py
##########
@@ -81,10 +84,12 @@ def get_conn(self) -> Connection:
delegate=_boolify(extra.get('kerberos__delegate', False)),
ca_bundle=extra.get('kerberos__ca_bundle'),
)
+ if _boolify(extra.get('impersonate_as_owner', False)):
+ user = os.getenv('AIRFLOW_CTX_DAG_OWNER', None)
Review comment:
Should this fall back to `db.login` if `AIRFLOW_CTX_DAG_OWNER` is not set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21451: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21451:
URL: https://github.com/apache/airflow/pull/21451#issuecomment-1040253085
You need to fix static checks (And rebase as some unrelated errors have been fixed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pragyak412 commented on pull request #21451: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
pragyak412 commented on pull request #21451:
URL: https://github.com/apache/airflow/pull/21451#issuecomment-1043952199
@potiuk Can you suggest anything that has to be changed now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21451: TrinoHook add authentication via JWT token and Impersonation #19008
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21451:
URL: https://github.com/apache/airflow/pull/21451#issuecomment-1033405480
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #21451: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #21451:
URL: https://github.com/apache/airflow/pull/21451#discussion_r809741809
##########
File path: tests/providers/trino/hooks/test_trino.py
##########
@@ -82,6 +83,21 @@ def test_get_conn_kerberos_auth(self, mock_get_connection, mock_connect, mock_au
)
TrinoHook().get_conn()
self.assert_connection_called_with(mock_connect, auth=mock_auth)
+
Review comment:
```suggestion
```
##########
File path: airflow/providers/trino/hooks/trino.py
##########
@@ -81,10 +84,14 @@ def get_conn(self) -> Connection:
delegate=_boolify(extra.get('kerberos__delegate', False)),
ca_bundle=extra.get('kerberos__ca_bundle'),
)
+
Review comment:
```suggestion
```
##########
File path: airflow/providers/trino/hooks/trino.py
##########
@@ -81,10 +84,14 @@ def get_conn(self) -> Connection:
delegate=_boolify(extra.get('kerberos__delegate', False)),
ca_bundle=extra.get('kerberos__ca_bundle'),
)
+
+ if _boolify(extra.get('impersonate_as_owner', False)):
+ user = os.getenv('AIRFLOW_CTX_DAG_OWNER', None)
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21451: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21451:
URL: https://github.com/apache/airflow/pull/21451#issuecomment-1040253085
You need to fix static checks (And rebase as some unrelated errors have been fixed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21451: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21451:
URL: https://github.com/apache/airflow/pull/21451#issuecomment-1044568576
Those connections/extras are not documented really. Could you please add the documentation in docstring and maybe even (as trino hook becomes more and more attribute-heavy) describe it the form similar to (you can look in detail how it is done there):
https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-apache-hdfs/connections.rst
Result of this is https://airflow.apache.org/docs/apache-airflow-providers-apache-hdfs/stable/connections.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org