You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/24 14:53:01 UTC
[GitHub] [arrow-datafusion] NGA-TRAN commented on a change in pull request #387: Optimize to_timestamp function
NGA-TRAN commented on a change in pull request #387:
URL: https://github.com/apache/arrow-datafusion/pull/387#discussion_r638017200
##########
File path: datafusion/src/optimizer/constant_folding.rs
##########
@@ -632,6 +662,29 @@ mod tests {
return format!("{:?}", optimized_plan);
}
+ #[test]
+ fn to_timestamp_expr() {
+ let table_scan = test_table_scan().unwrap();
+ let proj = vec![Expr::ScalarFunction {
+ args: vec![Expr::Literal(ScalarValue::Utf8(Some(
+ "2020-09-08T12:00:00+00:00".to_string(),
+ )))],
+ fun: BuiltinScalarFunction::ToTimestamp,
+ }];
+ let plan = LogicalPlanBuilder::from(&table_scan)
+ .project(proj)
+ .unwrap()
+ .build()
+ .unwrap();
+
+ let expected = format!(
+ "Projection: TimestampNanosecond(1599566400000000000)\
+ \n TableScan: test projection=None",
+ );
+ let actual = get_optimized_plan_formatted(&plan, &chrono::Utc::now());
+ assert_eq!(expected, actual);
+ }
+
Review comment:
The positive test looks great. How about a negative test with empty argument and another negative test with non-timestamp argument
##########
File path: datafusion/src/optimizer/constant_folding.rs
##########
@@ -217,6 +218,35 @@ impl<'a> ExprRewriter for ConstantRewriter<'a> {
.query_execution_start_time
.timestamp_nanos(),
))),
+ Expr::ScalarFunction {
+ fun: BuiltinScalarFunction::ToTimestamp,
+ args,
+ } => {
+ if !args.is_empty() {
+ match &args[0] {
+ Expr::Literal(ScalarValue::Utf8(Some(val))) => {
+ match string_to_timestamp_nanos(val) {
+ Ok(timestamp) => Expr::Literal(
+ ScalarValue::TimestampNanosecond(Some(timestamp)),
+ ),
+ _ => Expr::ScalarFunction {
+ fun: BuiltinScalarFunction::ToTimestamp,
+ args,
+ },
+ }
+ }
+ _ => Expr::ScalarFunction {
+ fun: BuiltinScalarFunction::ToTimestamp,
+ args,
+ },
+ }
+ } else {
+ Expr::ScalarFunction {
+ fun: BuiltinScalarFunction::ToTimestamp,
+ args,
+ }
+ }
+ }
Review comment:
What happen if the `args.is_empty()`? Do we use a default value or return syntax error we simply return `false` for this expression?
##########
File path: datafusion/src/optimizer/constant_folding.rs
##########
@@ -632,6 +662,29 @@ mod tests {
return format!("{:?}", optimized_plan);
}
+ #[test]
+ fn to_timestamp_expr() {
+ let table_scan = test_table_scan().unwrap();
+ let proj = vec![Expr::ScalarFunction {
+ args: vec![Expr::Literal(ScalarValue::Utf8(Some(
+ "2020-09-08T12:00:00+00:00".to_string(),
+ )))],
+ fun: BuiltinScalarFunction::ToTimestamp,
+ }];
+ let plan = LogicalPlanBuilder::from(&table_scan)
+ .project(proj)
+ .unwrap()
+ .build()
+ .unwrap();
+
+ let expected = format!(
+ "Projection: TimestampNanosecond(1599566400000000000)\
+ \n TableScan: test projection=None",
+ );
+ let actual = get_optimized_plan_formatted(&plan, &chrono::Utc::now());
+ assert_eq!(expected, actual);
Review comment:
Nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org