You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/09 19:44:58 UTC

[jira] [Commented] (KAFKA-4517) Remove kafka-consumer-offset-checker.sh script since already deprecated in Kafka 9

    [ https://issues.apache.org/jira/browse/KAFKA-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736132#comment-15736132 ] 

ASF GitHub Bot commented on KAFKA-4517:
---------------------------------------

GitHub user jeffwidman opened a pull request:

    https://github.com/apache/kafka/pull/2236

    KAFKA-4517: Remove deprecated shell script

    Remove the kafka-consumer-offset-checker.sh script completely since it
    was already deprecated in Kafka9
    
    Currently it's quite confusing to new Kafka operators that this script
    exists because it seems to do exactly what they want for checking
    offsets, only to later realize they should instead use
    kafka-consumer-groups.sh script

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeffwidman/kafka KAFKA-4517

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2236
    
----
commit c54fa291a4efcdfedf41bfbb2ba03a0ab7338c9b
Author: Jeff Widman <je...@jeffwidman.com>
Date:   2016-12-09T19:38:33Z

    KAFKA-4517: Remove deprecated shell script
    
    Remove the kafka-consumer-offset-checker.sh script completely since it
    was already deprecated in Kafka9
    
    Currently it's quite confusing to new Kafka operators that this script
    exists because it seems to do exactly what they want for checking
    offsets, only to later realize they should instead use
    kafka-consumer-groups.sh script

----


> Remove kafka-consumer-offset-checker.sh script since already deprecated in Kafka 9
> ----------------------------------------------------------------------------------
>
>                 Key: KAFKA-4517
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4517
>             Project: Kafka
>          Issue Type: Task
>    Affects Versions: 0.10.1.0, 0.10.0.0, 0.10.0.1
>            Reporter: Jeff Widman
>            Priority: Minor
>
> Kafka 9 deprecated kafka-consumer-offset-checker.sh (kafka.tools.ConsumerOffsetChecker) in favor of kafka-consumer-groups.sh (kafka.admin.ConsumerGroupCommand). 
> Since this was deprecated in 9, and the full functionality of the old script appears to be available in the new script, can we remove the old shell script in 10? 
> From an Ops perspective, it's confusing when I'm trying to check consumer offsets that I open the bin directory, and see a script that seems to do exactly what I want, only to later discover that I'm not supposed to use it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)