[GitHub] [spark] HyukjinKwon commented on a change in pull request #28652: [SPARK-31763][PYSPARK] Add `inputFiles` method in PySpark DataFrame Class.

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #28652:
URL: https://github.com/apache/spark/pull/28652#discussion_r430980184



##########
File path: python/pyspark/sql/tests/test_dataframe.py
##########
@@ -820,6 +822,21 @@ def test_same_semantics_error(self):
             with self.assertRaisesRegexp(ValueError, "should be of DataFrame.*int"):
                 self.spark.range(10).sameSemantics(1)
 
+    def test_input_files(self):
+        tmpPath = tempfile.mkdtemp()

Review comment:
       Let's to a try-finally, and use `this_naming_rule` per PEP8.
   
   ```python
   tpath = tempfile.mkdtemp()
   shutil.rmtree(tpath)
   try:
       ...
   finally:
       shutil.rmtree(tpath)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org