[GitHub] [spark] ulysses-you commented on a change in pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #34065:
URL: https://github.com/apache/spark/pull/34065#discussion_r713639032



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -262,7 +262,7 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
               // This join could be very slow or OOM
               val buildSide = getSmallerSide(left, right)
               Seq(joins.BroadcastNestedLoopJoinExec(
-                planLater(left), planLater(right), buildSide, joinType, nonEquiCond))
+                planLater(left), planLater(right), buildSide, joinType, j.condition))

Review comment:
       We would never go to this code path. For equi-join we always use smj by default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org