You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2011/04/18 19:26:05 UTC

[jira] [Created] (HADOOP-7230) Move -fs usage tests from hdfs into common

Move -fs usage tests from hdfs into common
------------------------------------------

                 Key: HADOOP-7230
                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
             Project: Hadoop Common
          Issue Type: Test
          Components: test
    Affects Versions: 0.23.0
            Reporter: Daryn Sharp
            Assignee: Daryn Sharp


The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021265#comment-13021265 ] 

Hadoop QA commented on HADOOP-7230:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12476633/HADOOP-7230.patch
  against trunk revision 1092853.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 61 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/350//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/350//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/350//console

This message is automatically generated.

> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021196#comment-13021196 ] 

Aaron T. Myers commented on HADOOP-7230:
----------------------------------------

Also, I don't think the precommit Hudson job is working at the moment for common, so you might want to run it and paste the results here yourself.

> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-7230:
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.0
           Status: Resolved  (was: Patch Available)

I have committed this.  Thanks, Daryn!

Thanks also Aaron for reviewing it.

> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021193#comment-13021193 ] 

Aaron T. Myers commented on HADOOP-7230:
----------------------------------------

Thanks a lot for this, Daryn. I've reviewed the code and it looks good to me.

> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-7230:
--------------------------------

    Attachment: HADOOP-7230.patch

Copy all the fs -help tests into common.  Will remove from hdfs after this change is committed.

> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-7230:
--------------------------------

    Status: Patch Available  (was: Open)

> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Hudson (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021276#comment-13021276 ] 

Hudson commented on HADOOP-7230:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #558 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/558/])
    HADOOP-7230. Move "fs -help" shell command tests from HDFS to COMMOM.  Contributed by Daryn Sharp


> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-7230:
-----------------------------------

    Hadoop Flags: [Reviewed]

+1

> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Hudson (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023192#comment-13023192 ] 

Hudson commented on HADOOP-7230:
--------------------------------

Integrated in Hadoop-Common-trunk #666 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk/666/])
    HADOOP-7230. Move "fs -help" shell command tests from HDFS to COMMOM.  Contributed by Daryn Sharp


> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7230) Move -fs usage tests from hdfs into common

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HADOOP-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021250#comment-13021250 ] 

Daryn Sharp commented on HADOOP-7230:
-------------------------------------

     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 61 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.

> Move -fs usage tests from hdfs into common
> ------------------------------------------
>
>                 Key: HADOOP-7230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7230
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7230.patch
>
>
> The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text.  The usages have no ties to hdfs, so they should be moved into common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira