You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (JIRA)" <ji...@apache.org> on 2018/12/05 10:22:00 UTC

[jira] [Commented] (HBASE-21550) Add a new method preCreateTableRegionInfos for MasterObserver which allows CPs to modify the TableDescriptor

    [ https://issues.apache.org/jira/browse/HBASE-21550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709879#comment-16709879 ] 

Duo Zhang commented on HBASE-21550:
-----------------------------------

Since we only a new method into the MasterObserver, and for java 8 we have default method for interface, I do not think it is an incompatible change. So maybe we can also commit to branch-2.1 and branch-2.0? [~stack]

Also ping [~zghaobac].

> Add a new method preCreateTableRegionInfos for MasterObserver which allows CPs to modify the TableDescriptor
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-21550
>                 URL: https://issues.apache.org/jira/browse/HBASE-21550
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0
>
>         Attachments: HBASE-21550.patch
>
>
> Before 2.0, we will pass a HTableDescriptor and the CPs can modify the schema of a table, but now we will pass a TableDescriptor, which is immutable. I think it is correct to pass an immutable instance here, but we should have a return value for this method to allow CPs to return a new TableDescriptor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)