You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Marc Slemko <ma...@znep.com> on 1997/06/10 02:22:25 UTC

[PATCH][CVS] minor log_accum.pl changes

These changes set the umask before committing to help files end up with
the correct permissions and add a PR: bit to the default template file, to
be used if a commit addresss a PR.

It would be nice to update it further, but not right now.  I think the new
FreeBSD one (this was originally borrowed from FreeBSD) handles branches
better.

Index: log_accum.pl
===================================================================
RCS file: /export/home/cvs/CVSROOT/log_accum.pl,v
retrieving revision 1.24
diff -c -r1.24 log_accum.pl
*** log_accum.pl	1997/06/04 04:43:56	1.24
--- log_accum.pl	1997/06/10 00:18:43
***************
*** 346,351 ****
--- 346,356 ----
  ############################################################
  
  #
+ # Setup environment
+ #
+ umask (002);
+ 
+ #
  # Initialize basic variables
  #
  $id = getpgrp();
***************
*** 406,412 ****
      push (@added_files,   split) if ($state == $STATE_ADDED);
      push (@removed_files, split) if ($state == $STATE_REMOVED);
      if ($state == $STATE_LOG) {
! 	if (/^Reviewed by:$/i ||
  	    /^Submitted by:$/i ||
  	    /^Obtained from:$/i) {
  	    next;
--- 411,418 ----
      push (@added_files,   split) if ($state == $STATE_ADDED);
      push (@removed_files, split) if ($state == $STATE_REMOVED);
      if ($state == $STATE_LOG) {
! 	if (/^PR:$/i ||
!             /^Reviewed by:$/i ||
  	    /^Submitted by:$/i ||
  	    /^Obtained from:$/i) {
  	    next;
Index: rcstemplate
===================================================================
RCS file: /export/home/cvs/CVSROOT/rcstemplate,v
retrieving revision 1.1
diff -c -r1.1 rcstemplate
*** rcstemplate	1996/01/14 16:08:21	1.1
--- rcstemplate	1997/06/10 00:18:43
***************
*** 1,6 ****
--- 1,7 ----
  Reviewed by:	
  Submitted by:	
  Obtained from:
+ PR: 
  CVS: ----------------------------------------------------------------------
  CVS: Obtained from:
  CVS:   If this change has been taken from another system, such as NCSA,
***************
*** 13,15 ****
--- 14,19 ----
  CVS:   If this code has been contributed to Apache by someone else; i.e.,
  CVS:   they sent us a patch or a new module, then include their name/email
  CVS:   address here. If this is your work then delete this line.
+ CVS: PR:
+ CVS:   If this change addresses a PR in the Apache bug database, enter 
+ CVS:   the number here.


Re: [PATCH][CVS] minor log_accum.pl changes

Posted by Dean Gaudet <dg...@arctic.org>.
Sounds good to me, +1

On Mon, 9 Jun 1997, Marc Slemko wrote:

> These changes set the umask before committing to help files end up with
> the correct permissions and add a PR: bit to the default template file, to
> be used if a commit addresss a PR.
> 
> It would be nice to update it further, but not right now.  I think the new
> FreeBSD one (this was originally borrowed from FreeBSD) handles branches
> better.
> 
> Index: log_accum.pl
> ===================================================================
> RCS file: /export/home/cvs/CVSROOT/log_accum.pl,v
> retrieving revision 1.24
> diff -c -r1.24 log_accum.pl
> *** log_accum.pl	1997/06/04 04:43:56	1.24
> --- log_accum.pl	1997/06/10 00:18:43
> ***************
> *** 346,351 ****
> --- 346,356 ----
>   ############################################################
>   
>   #
> + # Setup environment
> + #
> + umask (002);
> + 
> + #
>   # Initialize basic variables
>   #
>   $id = getpgrp();
> ***************
> *** 406,412 ****
>       push (@added_files,   split) if ($state == $STATE_ADDED);
>       push (@removed_files, split) if ($state == $STATE_REMOVED);
>       if ($state == $STATE_LOG) {
> ! 	if (/^Reviewed by:$/i ||
>   	    /^Submitted by:$/i ||
>   	    /^Obtained from:$/i) {
>   	    next;
> --- 411,418 ----
>       push (@added_files,   split) if ($state == $STATE_ADDED);
>       push (@removed_files, split) if ($state == $STATE_REMOVED);
>       if ($state == $STATE_LOG) {
> ! 	if (/^PR:$/i ||
> !             /^Reviewed by:$/i ||
>   	    /^Submitted by:$/i ||
>   	    /^Obtained from:$/i) {
>   	    next;
> Index: rcstemplate
> ===================================================================
> RCS file: /export/home/cvs/CVSROOT/rcstemplate,v
> retrieving revision 1.1
> diff -c -r1.1 rcstemplate
> *** rcstemplate	1996/01/14 16:08:21	1.1
> --- rcstemplate	1997/06/10 00:18:43
> ***************
> *** 1,6 ****
> --- 1,7 ----
>   Reviewed by:	
>   Submitted by:	
>   Obtained from:
> + PR: 
>   CVS: ----------------------------------------------------------------------
>   CVS: Obtained from:
>   CVS:   If this change has been taken from another system, such as NCSA,
> ***************
> *** 13,15 ****
> --- 14,19 ----
>   CVS:   If this code has been contributed to Apache by someone else; i.e.,
>   CVS:   they sent us a patch or a new module, then include their name/email
>   CVS:   address here. If this is your work then delete this line.
> + CVS: PR:
> + CVS:   If this change addresses a PR in the Apache bug database, enter 
> + CVS:   the number here.
> 
>