You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by sh...@apache.org on 2010/06/17 23:11:24 UTC
svn commit: r955749 - /qpid/trunk/qpid/cpp/src/qpid/acl/AclReader.cpp
Author: shuston
Date: Thu Jun 17 21:11:24 2010
New Revision: 955749
URL: http://svn.apache.org/viewvc?rev=955749&view=rev
Log:
Consistent comparison of unsigned values; clarify usage as well as removing potential bad compare.
Modified:
qpid/trunk/qpid/cpp/src/qpid/acl/AclReader.cpp
Modified: qpid/trunk/qpid/cpp/src/qpid/acl/AclReader.cpp
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/acl/AclReader.cpp?rev=955749&r1=955748&r2=955749&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qpid/acl/AclReader.cpp (original)
+++ qpid/trunk/qpid/cpp/src/qpid/acl/AclReader.cpp Thu Jun 17 21:11:24 2010
@@ -356,7 +356,8 @@ bool AclReader::processGroupLine(tokList
addName(toks[i], citr->second);
}
} else {
- if (toksSize < (cont ? 2 : 3)) {
+ const unsigned minimumSize = (cont ? 2 : 3);
+ if (toksSize < minimumSize) {
errorStream << ACL_FORMAT_ERR_LOG_PREFIX << "Line : " << lineNumber
<< ", Insufficient tokens for group definition.";
return false;
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org