You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/24 20:40:33 UTC

[GitHub] [airflow] potiuk opened a new pull request #15514: Removes unnecessary AzureContainerInstance connection type

potiuk opened a new pull request #15514:
URL: https://github.com/apache/airflow/pull/15514

The AzureContainerInstanceHook was derived from AzureBaseHook
and it did not add any new connection fields. Instead
it duplicated the tennantId and subscriptionId extr behaviour,
but it never worked, because it duplicated the fields
from the AzureBaseHook - and caused a lot of warnings when
AzureProvider was added.

This change sets the default connection type for the
AzureContainerInstanceHook to be azure_default and the
connection type to be 'azure'.

Those defaults are much more 'sane'. The existing connections
will continue to work, only when you open them in the UI, they
will display the extras directly rather than in dedicated fields
until the user changes the connection type to "azure" which will
fix the display.

So no disruptions, just temporary UI/Editing glitch. No more warnings
printed when Azure provider is added.

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #15514: Removes unnecessary AzureContainerInstance connection type

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #15514:
URL: https://github.com/apache/airflow/pull/15514


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #15514: Removes unnecessary AzureContainerInstance connection type

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #15514:
URL: https://github.com/apache/airflow/pull/15514


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15514: Removes unnecessary AzureContainerInstance connection type

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #15514:
URL: https://github.com/apache/airflow/pull/15514#issuecomment-826252077


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15514: Removes unnecessary AzureContainerInstance connection type

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #15514:
URL: https://github.com/apache/airflow/pull/15514#issuecomment-826252077


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org