[GitHub] [spark] zsxwing commented on a change in pull request #34901: [SPARK-37646][SQL]Avoid touching Scala reflection APIs in the lit function

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #34901:
URL: https://github.com/apache/spark/pull/34901#discussion_r768926270



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala
##########
@@ -932,7 +932,19 @@ class ColumnExpressionSuite extends QueryTest with SharedSparkSession {
       testData2.collect().toSeq.map(r => Row(r.getInt(0) ^ r.getInt(1) ^ 39)))
   }
 
+  test("SPARK-37646: lit") {
+    assert(lit($"foo") == $"foo")

Review comment:
       I don't find any unit tests like this. So just add simple tests to cover 3 cases in the code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org