Finalizing the new Resource API

[Carsten Ziegeler <cz...@apache.org>]

Hi,

I think it's time to finalize the changes on our resource API and get
a new release out.
The new CRUD support (SLING-2530) seems to be stable and can therefore
considered to be finished.

I would like to get SLING-2541 into the release as well, right now we
have hard-coded dependencies to the jcr resource provider in other
providers like the fs or bundle provider. With the suggested mechanism
we would have a more general mechanism in place.

I think we could also tackle SLING-2538 which is about removing some
legacy handling.

And finally I see SLING-2385 which is about deprecating the unused
getResource(ResourceResolver, HttpServletRequest, String) method.

WDYT about these?

Anything else we really need for the next release?

Regards
Carsten
-- 
Carsten Ziegeler
cziegeler@apache.org

Re: Finalizing the new Resource API

[Ian Boston <ie...@tfd.co.uk>]

On 25 October 2012 02:27, Carsten Ziegeler <cz...@apache.org> wrote:
> Hi,
>
>>
>> I see 3 out of the 4 are assigned to you. If you need help them? I
>> would be happy to lend a hand, but will need to ask about exactly what
>> methods are safe to remove in SLING-2538 so as not to impact anyone
>> upstream.
> Thanks for the offer, I haven't looked in detail but it basically
> should be the special handling in SLING-2457 and the methods in
> ResourceUtil/AbstractResource where AbstractResource currently calls
> ResourceUtil instead vice versa.
> Before doing this I would like to see if no one is against this change :)


I have attached a patch to the issue which I think addresses it, but I
am not certain.
There are 2 changes. I inverted the call from
AbstractResource.getParent(...) to ResourceUtil.getParent() which was
deprecated (moved the code).
I also removed the catch AbstractMethodError.

Is that what was wanted ?
(not committed).
Ian

Re: Finalizing the new Resource API

[Carsten Ziegeler <cz...@apache.org>]

Hi,

>
> I see 3 out of the 4 are assigned to you. If you need help them? I
> would be happy to lend a hand, but will need to ask about exactly what
> methods are safe to remove in SLING-2538 so as not to impact anyone
> upstream.
Thanks for the offer, I haven't looked in detail but it basically
should be the special handling in SLING-2457 and the methods in
ResourceUtil/AbstractResource where AbstractResource currently calls
ResourceUtil instead vice versa.
Before doing this I would like to see if no one is against this change :)

>
> SLING-2470 (BND annotations in package-info.java): nice to have but not vital.
Yepp, if someone wants to tackle it, fine - if not it's not blocking.

> SLING-2469  (API for query support in CRUD): I can see this being
> useful to add to the API even if its not implemented in anything
> shipped with Sling. I can imagine that someone writing an application
> based on Sling will want to issue weird and wonderful queries targeted
> against an underlying CRUD provider. If its part of SLING-2530 ignore
> me. (API for query support in CRUD)
Yepp, this is already handled/implemented with SLING-2530

>
> Looking at ones that are unscheduled and may impact the API:
> Is this still relevant ?
> https://issues.apache.org/jira/browse/SLING-1176 (ability for a
> ResourceResolver to indicate access denied)
Good question, I think it is not really relevant - nearly three years
since it was opened and no one needed it since then :)

Regards
Carsten
>
>
> Ian
>
>
>>
>> Regards
>> Carsten
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org



-- 
Carsten Ziegeler
cziegeler@apache.org

Re: Finalizing the new Resource API

[Ian Boston <ie...@tfd.co.uk>]

On 24 October 2012 18:25, Carsten Ziegeler <cz...@apache.org> wrote:
> Hi,
>
> I think it's time to finalize the changes on our resource API and get
> a new release out.
> The new CRUD support (SLING-2530) seems to be stable and can therefore
> considered to be finished.
>
> I would like to get SLING-2541 into the release as well, right now we
> have hard-coded dependencies to the jcr resource provider in other
> providers like the fs or bundle provider. With the suggested mechanism
> we would have a more general mechanism in place.
>
> I think we could also tackle SLING-2538 which is about removing some
> legacy handling.
>
> And finally I see SLING-2385 which is about deprecating the unused
> getResource(ResourceResolver, HttpServletRequest, String) method.
>
> WDYT about these?

All excellent inclusions and will help anyone downstream.

I see 3 out of the 4 are assigned to you. If you need help them? I
would be happy to lend a hand, but will need to ask about exactly what
methods are safe to remove in SLING-2538 so as not to impact anyone
upstream.

>
> Anything else we really need for the next release?

SLING-2470 (BND annotations in package-info.java): nice to have but not vital.
SLING-2469  (API for query support in CRUD): I can see this being
useful to add to the API even if its not implemented in anything
shipped with Sling. I can imagine that someone writing an application
based on Sling will want to issue weird and wonderful queries targeted
against an underlying CRUD provider. If its part of SLING-2530 ignore
me. (API for query support in CRUD)


Looking at ones that are unscheduled and may impact the API:
Is this still relevant ?
https://issues.apache.org/jira/browse/SLING-1176 (ability for a
ResourceResolver to indicate access denied)


Ian


>
> Regards
> Carsten
> --
> Carsten Ziegeler
> cziegeler@apache.org