You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Antonio Fornie <an...@gmail.com> on 2013/12/19 08:37:36 UTC
Review Request 16373: SecurityProfile for NiciraNvpApi,
including Unit and Integration tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16373/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
SecurityProfile for NiciraNvpApi, including Unit and
Integration tests
Diffs
-----
plugins/network-elements/nicira-nvp/pom.xml 3bc8d14
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 6f695ad
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityProfile.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java 26517b5
plugins/network-elements/nicira-nvp/test/resources/config.properties PRE-CREATION
Diff: https://reviews.apache.org/r/16373/diff/
Testing
-------
Unit and Integration Tests, both builds for this single submodule and for the whole stack with both default and integration profiles
Thanks,
Antonio Fornie
Re: Review Request 16373: SecurityProfile for NiciraNvpApi,
including Unit and Integration tests
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16373/#review30825
-----------------------------------------------------------
Ship it!
dad42494983bb2ada670d18cb25cdae4e3cec63b
- daan Hoogland
On Dec. 23, 2013, 12:10 p.m., Antonio Fornie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16373/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2013, 12:10 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> SecurityProfile for NiciraNvpApi, including Unit and
> Integration tests
>
>
> Diffs
> -----
>
> plugins/network-elements/nicira-nvp/pom.xml 3bc8d14
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessConfiguration.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessRule.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Acl.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AclRule.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 6f695ad
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityProfile.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityRule.java PRE-CREATION
> plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java PRE-CREATION
> plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java 26517b5
> plugins/network-elements/nicira-nvp/test/resources/config.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16373/diff/
>
>
> Testing
> -------
>
> Unit and Integration Tests, both builds for this single submodule and for the whole stack with both default and integration profiles
>
>
> Thanks,
>
> Antonio Fornie
>
>
Re: Review Request 16373: SecurityProfile for NiciraNvpApi,
including Unit and Integration tests
Posted by Antonio Fornie <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16373/
-----------------------------------------------------------
(Updated Dec. 23, 2013, 12:10 p.m.)
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Changes
-------
Just remove a comment line that is not really helping.
Repository: cloudstack-git
Description
-------
SecurityProfile for NiciraNvpApi, including Unit and
Integration tests
Diffs (updated)
-----
plugins/network-elements/nicira-nvp/pom.xml 3bc8d14
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessConfiguration.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Acl.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AclRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 6f695ad
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityProfile.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java 26517b5
plugins/network-elements/nicira-nvp/test/resources/config.properties PRE-CREATION
Diff: https://reviews.apache.org/r/16373/diff/
Testing
-------
Unit and Integration Tests, both builds for this single submodule and for the whole stack with both default and integration profiles
Thanks,
Antonio Fornie
Re: Review Request 16373: SecurityProfile for NiciraNvpApi,
including Unit and Integration tests
Posted by Antonio Fornie <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16373/
-----------------------------------------------------------
(Updated Dec. 23, 2013, 10:32 a.m.)
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Changes
-------
Missing license
Repository: cloudstack-git
Description
-------
SecurityProfile for NiciraNvpApi, including Unit and
Integration tests
Diffs (updated)
-----
plugins/network-elements/nicira-nvp/pom.xml 3bc8d14
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessConfiguration.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Acl.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AclRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 6f695ad
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityProfile.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java 26517b5
plugins/network-elements/nicira-nvp/test/resources/config.properties PRE-CREATION
Diff: https://reviews.apache.org/r/16373/diff/
Testing
-------
Unit and Integration Tests, both builds for this single submodule and for the whole stack with both default and integration profiles
Thanks,
Antonio Fornie
Re: Review Request 16373: SecurityProfile for NiciraNvpApi,
including Unit and Integration tests
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16373/#review30750
-----------------------------------------------------------
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java
<https://reviews.apache.org/r/16373/#comment58857>
missing license
- daan Hoogland
On Dec. 20, 2013, 3:36 p.m., Antonio Fornie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16373/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2013, 3:36 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> SecurityProfile for NiciraNvpApi, including Unit and
> Integration tests
>
>
> Diffs
> -----
>
> plugins/network-elements/nicira-nvp/pom.xml 3bc8d14
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessConfiguration.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessRule.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Acl.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AclRule.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 6f695ad
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityProfile.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityRule.java PRE-CREATION
> plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java PRE-CREATION
> plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java 26517b5
> plugins/network-elements/nicira-nvp/test/resources/config.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16373/diff/
>
>
> Testing
> -------
>
> Unit and Integration Tests, both builds for this single submodule and for the whole stack with both default and integration profiles
>
>
> Thanks,
>
> Antonio Fornie
>
>
Re: Review Request 16373: SecurityProfile for NiciraNvpApi,
including Unit and Integration tests
Posted by Antonio Fornie <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16373/
-----------------------------------------------------------
(Updated Dec. 20, 2013, 3:36 p.m.)
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Changes
-------
Added also ACL and some refactoring changes
Repository: cloudstack-git
Description
-------
SecurityProfile for NiciraNvpApi, including Unit and
Integration tests
Diffs (updated)
-----
plugins/network-elements/nicira-nvp/pom.xml 3bc8d14
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessConfiguration.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Acl.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AclRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 6f695ad
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityProfile.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SecurityRule.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java 26517b5
plugins/network-elements/nicira-nvp/test/resources/config.properties PRE-CREATION
Diff: https://reviews.apache.org/r/16373/diff/
Testing
-------
Unit and Integration Tests, both builds for this single submodule and for the whole stack with both default and integration profiles
Thanks,
Antonio Fornie