You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by vm...@apache.org on 2003/06/04 13:36:27 UTC
cvs commit: maven/src/plugins-build/junit-report/xdocs changes.xml
vmassol 2003/06/04 04:36:27
Modified: src/plugins-build/junit-report plugin.jelly project.xml
Added: src/plugins-build/junit-report/xdocs changes.xml
Log:
The maven.test.failure.ignore property is forced to true during the execution of the tests (so that report generation do not fail if the tests fail) but it is not reset to its initial value aftewards, thus causing issues for other plugins thereafter relying on it.
Revision Changes Path
1.6 +5 -1 maven/src/plugins-build/junit-report/plugin.jelly
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/maven/src/plugins-build/junit-report/plugin.jelly,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- plugin.jelly 1 Apr 2003 00:50:11 -0000 1.5
+++ plugin.jelly 4 Jun 2003 11:36:27 -0000 1.6
@@ -27,9 +27,13 @@
<j:if test="${unitTestSourcesPresent == 'true'}">
+ <!-- Make sure that the report is generated whether the tests pass or
+ not -->
+ <j:set var="ignoreTestFailureOld" value="${maven.test.failure.ignore}"/>
<j:set var="maven.test.failure.ignore" scope="parent" value="true"/>
<attainGoal name="test:test"/>
- <j:set var="maven.test.failure.ignore" scope="parent"/>
+ <j:set var="maven.test.failure.ignore" scope="parent"
+ value="${ignoreTestFailureOld}"/>
<j:set var="testReportsDirectory"
value="${pom.getPluginContext('maven-test-plugin').getVariable('maven.test.reportsDirectory')}"/>
1.12 +19 -2 maven/src/plugins-build/junit-report/project.xml
Index: project.xml
===================================================================
RCS file: /home/cvs/maven/src/plugins-build/junit-report/project.xml,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- project.xml 9 Apr 2003 01:06:47 -0000 1.11
+++ project.xml 4 Jun 2003 11:36:27 -0000 1.12
@@ -5,7 +5,7 @@
<pomVersion>3</pomVersion>
<id>maven-junit-report-plugin</id>
<name>Maven JUnit Report Plug-in</name>
- <currentVersion>1.2</currentVersion>
+ <currentVersion>1.3-SNAPSHOT</currentVersion>
<description/>
<shortDescription>Java Project Management Tools</shortDescription>
<url>http://maven.apache.org/reference/plugins/junit-report/</url>
@@ -14,7 +14,24 @@
<connection>scm:cvs:pserver:anoncvs@cvs.apache.org:/home/cvspublic:maven/src/plugins-build/junit-report/</connection>
<url>http://cvs.apache.org/viewcvs/maven/src/plugins-build/junit-report/</url>
</repository>
- <developers/>
+ <versions>
+ <version>
+ <id>1.3</id>
+ <name>1.3</name>
+ <tag>HEAD</tag>
+ </version>
+ </versions>
+ <developers>
+ <developer>
+ <name>Vincent Massol</name>
+ <id>vmassol</id>
+ <email>vmassol@pivolis.com</email>
+ <organization>Pivolis</organization>
+ <roles>
+ <role>Java Developer</role>
+ </roles>
+ </developer>
+ </developers>
<dependencies>
<dependency>
<groupId>commons-jelly</groupId>
1.1 maven/src/plugins-build/junit-report/xdocs/changes.xml
Index: changes.xml
===================================================================
<?xml version="1.0"?>
<document>
<properties>
<title>Changes</title>
<author email="vmassol@apache.org">Vincent Massol</author>
</properties>
<body>
<release version="1.3" date="in CVS">
<action dev="vmassol" type="fix">
The <code>maven.test.failure.ignore</code> is forced to true during
the execution of the tests (so that report generation do not fail
if the tests fail) but it is not reset to its initial value aftewards,
thus causing issues for other plugins thereafter relying on it.
</action>
</release>
<release version="1.2" date="?">
</release>
</body>
</document>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org