You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by shinrich <gi...@git.apache.org> on 2016/04/15 23:09:04 UTC
[GitHub] trafficserver pull request: TS-3909 Further trampoline crash fixes...
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/575
TS-3909 Further trampoline crash fixes.
We have been running with this fix in production since November or December 2015.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-3909
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #575
----
commit 695ddbcde91e384f710f917afd7f52d24699d752
Author: Susan Hinrichs <sh...@draggingnagging.corp.ne1.yahoo.com>
Date: 2016-04-15T17:13:21Z
Further trampoline crash fixes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3909 Further trampoline crash fixes...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3909 Further trampoline crash fixes...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/575#issuecomment-210828998
I think a semi-reliable regression test would be very difficult. This is fixing a timing based problem. You'd have to have a client open a connection. Send a little bit of data. Then wait for for the SM to timeout. The action eventually gets overwritten, so it is a rather narrow window for failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3909 Further trampoline crash fixes...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/575#issuecomment-210700064
Is this testable? What do you think about regression tests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---