You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/14 15:20:13 UTC
[GitHub] [kafka] ijuma opened a new pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
ijuma opened a new pull request #11757:
URL: https://github.com/apache/kafka/pull/11757
* Mention `acks=1` to `acks=all` change in 3.0.0 upgrade docs
* Have a separate section for 3.0.1 and 3.1.1 as some may skip the
3.0.0/3.1.0 section when upgrading to a bug fix.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #11757:
URL: https://github.com/apache/kafka/pull/11757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11757:
URL: https://github.com/apache/kafka/pull/11757#discussion_r806091862
##########
File path: docs/upgrade.html
##########
@@ -69,6 +69,13 @@ <h4><a id="upgrade_3_1_0" href="#upgrade_3_1_0">Upgrading to 3.1.0 from any vers
</li>
</ol>
+<h5><a id="upgrade_300_notable" href="#upgrade_301_notable">Notable changes in 3.1.1</a></h5>
Review comment:
My html-fu is not particularly strong, but it seems we should change the `id` and `href` tags for the new sections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11757:
URL: https://github.com/apache/kafka/pull/11757#issuecomment-1039385776
Btw, I made these changes because Spark has upgraded to 3.1.0 and there was some confusion regarding the compatibility implications of the upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11757:
URL: https://github.com/apache/kafka/pull/11757#issuecomment-1039793039
Thanks for the clarification! LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11757:
URL: https://github.com/apache/kafka/pull/11757#issuecomment-1039384837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #11757:
URL: https://github.com/apache/kafka/pull/11757#discussion_r806096638
##########
File path: docs/upgrade.html
##########
@@ -69,6 +69,13 @@ <h4><a id="upgrade_3_1_0" href="#upgrade_3_1_0">Upgrading to 3.1.0 from any vers
</li>
</ol>
+<h5><a id="upgrade_300_notable" href="#upgrade_301_notable">Notable changes in 3.1.1</a></h5>
Review comment:
Good catch, my bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11757:
URL: https://github.com/apache/kafka/pull/11757#issuecomment-1039384837
@hachikuji Thanks. Yes, I intend to fix those two branches so that they match what we have here excluding the 3.2 section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11757:
URL: https://github.com/apache/kafka/pull/11757#discussion_r806091862
##########
File path: docs/upgrade.html
##########
@@ -69,6 +69,13 @@ <h4><a id="upgrade_3_1_0" href="#upgrade_3_1_0">Upgrading to 3.1.0 from any vers
</li>
</ol>
+<h5><a id="upgrade_300_notable" href="#upgrade_301_notable">Notable changes in 3.1.1</a></h5>
Review comment:
My html-fu is not particularly strong, but it seems we should change the `id` and `href` tags for the new sections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #11757:
URL: https://github.com/apache/kafka/pull/11757#discussion_r806096638
##########
File path: docs/upgrade.html
##########
@@ -69,6 +69,13 @@ <h4><a id="upgrade_3_1_0" href="#upgrade_3_1_0">Upgrading to 3.1.0 from any vers
</li>
</ol>
+<h5><a id="upgrade_300_notable" href="#upgrade_301_notable">Notable changes in 3.1.1</a></h5>
Review comment:
Good catch, my bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #11757:
URL: https://github.com/apache/kafka/pull/11757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11757:
URL: https://github.com/apache/kafka/pull/11757#issuecomment-1039793039
Thanks for the clarification! LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org