[GitHub] [cloudstack] ravening commented on a change in pull request #4666: Fix bug in creating shared network

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #4666:
URL: https://github.com/apache/cloudstack/pull/4666#discussion_r587597691



##########
File path: ui/src/views/network/CreateSharedNetworkForm.vue
##########
@@ -592,11 +592,12 @@ export default {
           this.formPhysicalNetworkLoading = false
         }
       }).finally(() => {
-        if (isLastNetwork) {
+        if (this.formPhysicalNetworks.length > 0 && this.isObjectEmpty(this.formSelectedPhysicalNetwork)) {
           this.form.setFieldsValue({
             physicalnetworkid: 0
           })
-          this.handlePhysicalNetworkChange(this.formPhysicalNetworks[0])
+          const network = (this.formPhysicalNetworks.length > 0) ? this.formPhysicalNetworks[0] : physicalNetwork

Review comment:
       @weizhouapache no . try the change in commit caeaa1aadeea98bae1a14b733026f87c6f69dd63
   
   if that works for you, i will merge the commits to 1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org