You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-commits@lucene.apache.org by mi...@apache.org on 2006/12/19 12:31:28 UTC
svn commit: r488640 - in /lucene/java/trunk: ./
contrib/spellchecker/src/java/org/apache/lucene/search/spell/
src/java/org/apache/lucene/index/ src/java/org/apache/lucene/store/
src/test/org/apache/lucene/index/
Author: mikemccand
Date: Tue Dec 19 03:31:27 2006
New Revision: 488640
URL: http://svn.apache.org/viewvc?view=rev&rev=488640
Log:
LUCENE-748: add javadoc around semantics of Exception during IndexWriter.close()
LUCENE-129: fix finalizers to always call super.finalize
LUCENE-301: add new constructors IndexWriter({String,File,Directory}, Analyzer) that create index if it's not already there, else append
LUCENE-701: found two cases of "open IndexWriter for create while reader is open, on Windows" that I didn't properly fix; added new test cases
LUCENE-702: corrected some small javadoc issues
Modified:
lucene/java/trunk/CHANGES.txt
lucene/java/trunk/contrib/spellchecker/src/java/org/apache/lucene/search/spell/SpellChecker.java
lucene/java/trunk/src/java/org/apache/lucene/index/IndexReader.java
lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java
lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java
lucene/java/trunk/src/java/org/apache/lucene/index/TermInfosReader.java
lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java
lucene/java/trunk/src/java/org/apache/lucene/store/NativeFSLockFactory.java
lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexWriter.java
Modified: lucene/java/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/java/trunk/CHANGES.txt?view=diff&rev=488640&r1=488639&r2=488640
==============================================================================
--- lucene/java/trunk/CHANGES.txt (original)
+++ lucene/java/trunk/CHANGES.txt Tue Dec 19 03:31:27 2006
@@ -238,7 +238,7 @@
FSIndexInput/Output during finalize(). Besides sending an
IOException up to the GC, this may also be the cause intermittent
"The handle is invalid" IOExceptions on Windows when trying to
- close readers or writers. (Michael Busch via Mike McCandless).
+ close readers or writers. (Michael Busch via Mike McCandless)
26. LUCENE-702: Fix IndexWriter.addIndexes(*) to not corrupt the index
on any exceptions (eg disk full). The semantics of these methods
@@ -249,6 +249,10 @@
instance state consistent to what's actually in the index (Mike
McCandless).
+27. LUCENE-129: Change finalizers to do "try {...} finally
+ {super.finalize();}" to make sure we don't miss finalizers in
+ classes above us. (Esmond Pitt via Mike McCandless)
+
Optimizations
1. LUCENE-586: TermDocs.skipTo() is now more efficient for
@@ -348,6 +352,9 @@
7. Added in link to Clover Test Code Coverage Reports under the Develop section in Resources (Grant Ingersoll)
+ 8. LUCENE-748: Added details for semantics of IndexWriter.close on
+ hitting an Exception. (Jed Wesley-Smith via Mike McCandless)
+
Build
1. Added in clover test code coverage per http://issues.apache.org/jira/browse/LUCENE-721 To enable clover code coverage, you must have clover.jar in the ANT classpath and specify -Drun.clover=true on the command line.(Michael Busch and Grant Ingersoll)
@@ -369,6 +376,12 @@
3. Creating a Field with both an empty name and an empty value
now throws an IllegalArgumentException
(Daniel Naber)
+
+ 4. LUCENE-301: Added new IndexWriter({String,File,Directory},
+ Analyzer) constructors that do not take a boolean "create"
+ argument. These new constructors will create a new index if
+ necessary, else append to the existing one. (Dan Armbrust via
+ Mike McCandless)
New features
Modified: lucene/java/trunk/contrib/spellchecker/src/java/org/apache/lucene/search/spell/SpellChecker.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/contrib/spellchecker/src/java/org/apache/lucene/search/spell/SpellChecker.java?view=diff&rev=488640&r1=488639&r2=488640
==============================================================================
--- lucene/java/trunk/contrib/spellchecker/src/java/org/apache/lucene/search/spell/SpellChecker.java (original)
+++ lucene/java/trunk/contrib/spellchecker/src/java/org/apache/lucene/search/spell/SpellChecker.java Tue Dec 19 03:31:27 2006
@@ -342,8 +342,12 @@
}
protected void finalize() throws Throwable {
- if (reader != null) {
- reader.close();
+ try {
+ if (reader != null) {
+ reader.close();
+ }
+ } finally {
+ super.finalize();
}
}
}
Modified: lucene/java/trunk/src/java/org/apache/lucene/index/IndexReader.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/index/IndexReader.java?view=diff&rev=488640&r1=488639&r2=488640
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/index/IndexReader.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/index/IndexReader.java Tue Dec 19 03:31:27 2006
@@ -721,10 +721,14 @@
protected abstract void doClose() throws IOException;
/** Release the write lock, if needed. */
- protected void finalize() {
- if (writeLock != null) {
- writeLock.release(); // release write lock
- writeLock = null;
+ protected void finalize() throws Throwable {
+ try {
+ if (writeLock != null) {
+ writeLock.release(); // release write lock
+ writeLock = null;
+ }
+ } finally {
+ super.finalize();
}
}
Modified: lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java?view=diff&rev=488640&r1=488639&r2=488640
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java Tue Dec 19 03:31:27 2006
@@ -202,7 +202,7 @@
*/
public IndexWriter(String path, Analyzer a, boolean create)
throws IOException {
- this(FSDirectory.getDirectory(path, create), a, create, true);
+ init(path, a, create);
}
/**
@@ -222,7 +222,7 @@
*/
public IndexWriter(File path, Analyzer a, boolean create)
throws IOException {
- this(FSDirectory.getDirectory(path, create), a, create, true);
+ init(path, a, create);
}
/**
@@ -242,49 +242,125 @@
*/
public IndexWriter(Directory d, Analyzer a, boolean create)
throws IOException {
- this(d, a, create, false);
+ init(d, a, create, false);
+ }
+
+ /**
+ * Constructs an IndexWriter for the index in
+ * <code>path</code>, creating it first if it does not
+ * already exist, otherwise appending to the existing
+ * index. Text will be analyzed with <code>a</code>.
+ *
+ * @param path the path to the index directory
+ * @param a the analyzer to use
+ * @throws IOException if the directory cannot be
+ * created or read/written to
+ */
+ public IndexWriter(String path, Analyzer a)
+ throws IOException {
+ if (IndexReader.indexExists(path)) {
+ init(path, a, false);
+ } else {
+ init(path, a, true);
+ }
+ }
+
+ /**
+ * Constructs an IndexWriter for the index in
+ * <code>path</code>, creating it first if it does not
+ * already exist, otherwise appending to the existing
+ * index. Text will be analyzed with
+ * <code>a</code>.
+ *
+ * @param path the path to the index directory
+ * @param a the analyzer to use
+ * @throws IOException if the directory cannot be
+ * created or read/written to
+ */
+ public IndexWriter(File path, Analyzer a)
+ throws IOException {
+ if (IndexReader.indexExists(path)) {
+ init(path, a, false);
+ } else {
+ init(path, a, true);
+ }
+ }
+
+ /**
+ * Constructs an IndexWriter for the index in
+ * <code>d</code>, creating it first if it does not
+ * already exist, otherwise appending to the existing
+ * index. Text will be analyzed with <code>a</code>.
+ *
+ * @param d the index directory
+ * @param a the analyzer to use
+ * @throws IOException if the directory cannot be
+ * created or read/written to
+ */
+ public IndexWriter(Directory d, Analyzer a)
+ throws IOException {
+ if (IndexReader.indexExists(d)) {
+ init(d, a, false, false);
+ } else {
+ init(d, a, true, false);
+ }
}
private IndexWriter(Directory d, Analyzer a, final boolean create, boolean closeDir)
throws IOException {
- this.closeDir = closeDir;
- directory = d;
- analyzer = a;
-
- Lock writeLock = directory.makeLock(IndexWriter.WRITE_LOCK_NAME);
- if (!writeLock.obtain(writeLockTimeout)) // obtain write lock
- throw new IOException("Index locked for write: " + writeLock);
- this.writeLock = writeLock; // save it
-
- try {
- if (create) {
- // Try to read first. This is to allow create
- // against an index that's currently open for
- // searching. In this case we write the next
- // segments_N file with no segments:
- try {
- segmentInfos.read(directory);
- segmentInfos.clear();
- } catch (IOException e) {
- // Likely this means it's a fresh directory
- }
- segmentInfos.write(directory);
- } else {
+ init(d, a, create, closeDir);
+ }
+
+ private void init(String path, Analyzer a, final boolean create)
+ throws IOException {
+ init(FSDirectory.getDirectory(path, create, null, false), a, create, true);
+ }
+
+ private void init(File path, Analyzer a, final boolean create)
+ throws IOException {
+ init(FSDirectory.getDirectory(path, create, null, false), a, create, true);
+ }
+
+ private void init(Directory d, Analyzer a, final boolean create, boolean closeDir)
+ throws IOException {
+ this.closeDir = closeDir;
+ directory = d;
+ analyzer = a;
+
+ Lock writeLock = directory.makeLock(IndexWriter.WRITE_LOCK_NAME);
+ if (!writeLock.obtain(writeLockTimeout)) // obtain write lock
+ throw new IOException("Index locked for write: " + writeLock);
+ this.writeLock = writeLock; // save it
+
+ try {
+ if (create) {
+ // Try to read first. This is to allow create
+ // against an index that's currently open for
+ // searching. In this case we write the next
+ // segments_N file with no segments:
+ try {
segmentInfos.read(directory);
+ segmentInfos.clear();
+ } catch (IOException e) {
+ // Likely this means it's a fresh directory
}
-
- // Create a deleter to keep track of which files can
- // be deleted:
- deleter = new IndexFileDeleter(segmentInfos, directory);
- deleter.setInfoStream(infoStream);
- deleter.findDeletableFiles();
- deleter.deleteFiles();
-
- } catch (IOException e) {
- this.writeLock.release();
- this.writeLock = null;
- throw e;
+ segmentInfos.write(directory);
+ } else {
+ segmentInfos.read(directory);
}
+
+ // Create a deleter to keep track of which files can
+ // be deleted:
+ deleter = new IndexFileDeleter(segmentInfos, directory);
+ deleter.setInfoStream(infoStream);
+ deleter.findDeletableFiles();
+ deleter.deleteFiles();
+
+ } catch (IOException e) {
+ this.writeLock.release();
+ this.writeLock = null;
+ throw e;
+ }
}
/** Determines the largest number of documents ever merged by addDocument().
@@ -418,7 +494,38 @@
return IndexWriter.WRITE_LOCK_TIMEOUT;
}
- /** Flushes all changes to an index and closes all associated files. */
+ /**
+ * Flushes all changes to an index and closes all
+ * associated files.
+ *
+ * <p> If an Exception is hit during close, eg due to disk
+ * full or some other reason, then both the on-disk index
+ * and the internal state of the IndexWriter instance will
+ * be consistent. However, the close will not be complete
+ * even though part of it (flushing buffered documents)
+ * may have succeeded, so the write lock will still be
+ * held.</p>
+ *
+ * <p> If you can correct the underlying cause (eg free up
+ * some disk space) then you can call close() again.
+ * Failing that, if you want to force the write lock to be
+ * released (dangerous, because you may then lose buffered
+ * docs in the IndexWriter instance) then you can do
+ * something like this:</p>
+ *
+ * <pre>
+ * try {
+ * writer.close();
+ * } finally {
+ * if (IndexReader.isLocked(directory)) {
+ * IndexReader.unlock(directory);
+ * }
+ * }
+ * </pre>
+ *
+ * after which, you must be certain not to use the writer
+ * instance anymore.</p>
+ */
public synchronized void close() throws IOException {
flushRamSegments();
ramDirectory.close();
@@ -431,10 +538,14 @@
}
/** Release the write lock, if needed. */
- protected void finalize() throws IOException {
- if (writeLock != null) {
- writeLock.release(); // release write lock
- writeLock = null;
+ protected void finalize() throws Throwable {
+ try {
+ if (writeLock != null) {
+ writeLock.release(); // release write lock
+ writeLock = null;
+ }
+ } finally {
+ super.finalize();
}
}
@@ -479,11 +590,12 @@
* {@link #setMaxFieldLength(int)} terms for a given field, the remainder are
* discarded.
*
- * Note that if an Exception is hit (eg disk full) then
- * the index will be consistent, but this document will
- * not have been added. Furthermore, it's possible the
- * index will have one segment in non-compound format even
- * when using compound files.
+ * <p> Note that if an Exception is hit (eg disk full)
+ * then the index will be consistent, but this document
+ * may not have been added. Furthermore, it's possible
+ * the index will have one segment in non-compound format
+ * even when using compound files (when a merge has
+ * partially succeeded).</p>
*/
public void addDocument(Document doc) throws IOException {
addDocument(doc, analyzer);
@@ -495,8 +607,8 @@
* {@link #setMaxFieldLength(int)} terms for a given field, the remainder are
* discarded.
*
- * See @link #addDocument(Document) for details on index
- * state after an IOException.
+ * <p>See {@link #addDocument(Document)} for details on
+ * index and IndexWriter state after an Exception.</p>
*/
public void addDocument(Document doc, Analyzer analyzer) throws IOException {
DocumentWriter dw =
Modified: lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java?view=diff&rev=488640&r1=488639&r2=488640
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java Tue Dec 19 03:31:27 2006
@@ -187,10 +187,13 @@
}
}
- protected void finalize() {
- // patch for pre-1.4.2 JVMs, whose ThreadLocals leak
- termVectorsLocal.set(null);
- super.finalize();
+ protected void finalize() throws Throwable {
+ try {
+ // patch for pre-1.4.2 JVMs, whose ThreadLocals leak
+ termVectorsLocal.set(null);
+ } finally {
+ super.finalize();
+ }
}
protected void doCommit() throws IOException {
Modified: lucene/java/trunk/src/java/org/apache/lucene/index/TermInfosReader.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/index/TermInfosReader.java?view=diff&rev=488640&r1=488639&r2=488640
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/index/TermInfosReader.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/index/TermInfosReader.java Tue Dec 19 03:31:27 2006
@@ -55,9 +55,13 @@
fieldInfos, true);
}
- protected void finalize() {
- // patch for pre-1.4.2 JVMs, whose ThreadLocals leak
- enumerators.set(null);
+ protected void finalize() throws Throwable {
+ try {
+ // patch for pre-1.4.2 JVMs, whose ThreadLocals leak
+ enumerators.set(null);
+ } finally {
+ super.finalize();
+ }
}
public int getSkipInterval() {
Modified: lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java?view=diff&rev=488640&r1=488639&r2=488640
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java Tue Dec 19 03:31:27 2006
@@ -554,8 +554,12 @@
return length;
}
- protected void finalize() throws IOException {
- close(); // close the file
+ protected void finalize() throws Throwable {
+ try {
+ close(); // close the file
+ } finally {
+ super.finalize();
+ }
}
public Object clone() {
@@ -607,8 +611,12 @@
return file.length();
}
- protected void finalize() throws IOException {
- close(); // close the file
+ protected void finalize() throws Throwable {
+ try {
+ close(); // close the file
+ } finally {
+ super.finalize();
+ }
}
}
Modified: lucene/java/trunk/src/java/org/apache/lucene/store/NativeFSLockFactory.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/store/NativeFSLockFactory.java?view=diff&rev=488640&r1=488639&r2=488640
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/store/NativeFSLockFactory.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/store/NativeFSLockFactory.java Tue Dec 19 03:31:27 2006
@@ -333,9 +333,13 @@
return "NativeFSLock@" + path;
}
- public void finalize() {
- if (isLocked()) {
- release();
+ public void finalize() throws Throwable {
+ try {
+ if (isLocked()) {
+ release();
+ }
+ } finally {
+ super.finalize();
}
}
}
Modified: lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexWriter.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexWriter.java?view=diff&rev=488640&r1=488639&r2=488640
==============================================================================
--- lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexWriter.java (original)
+++ lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexWriter.java Tue Dec 19 03:31:27 2006
@@ -39,7 +39,7 @@
IndexWriter.setDefaultWriteLockTimeout(2000);
assertEquals(2000, IndexWriter.getDefaultWriteLockTimeout());
- writer = new IndexWriter(dir, new WhitespaceAnalyzer(), true);
+ writer = new IndexWriter(dir, new WhitespaceAnalyzer());
IndexWriter.setDefaultWriteLockTimeout(1000);
@@ -58,7 +58,7 @@
reader.close();
// test doc count before segments are merged/index is optimized
- writer = new IndexWriter(dir, new WhitespaceAnalyzer(), false);
+ writer = new IndexWriter(dir, new WhitespaceAnalyzer());
assertEquals(100, writer.docCount());
writer.close();
@@ -68,7 +68,7 @@
reader.close();
// optimize the index and check that the new doc count is correct
- writer = new IndexWriter(dir, new WhitespaceAnalyzer(), false);
+ writer = new IndexWriter(dir, new WhitespaceAnalyzer());
writer.optimize();
assertEquals(60, writer.docCount());
writer.close();
@@ -445,29 +445,102 @@
if (tempDir == null)
throw new IOException("java.io.tmpdir undefined, cannot run test");
File indexDir = new File(tempDir, "lucenetestindexwriter");
- Directory dir = FSDirectory.getDirectory(indexDir, true);
- // add one document & close writer
- IndexWriter writer = new IndexWriter(dir, new WhitespaceAnalyzer(), true);
- addDoc(writer);
- writer.close();
+ try {
+ Directory dir = FSDirectory.getDirectory(indexDir, true);
- // now open reader:
- IndexReader reader = IndexReader.open(dir);
- assertEquals("should be one document", reader.numDocs(), 1);
+ // add one document & close writer
+ IndexWriter writer = new IndexWriter(dir, new WhitespaceAnalyzer(), true);
+ addDoc(writer);
+ writer.close();
- // now open index for create:
- writer = new IndexWriter(dir, new WhitespaceAnalyzer(), true);
- assertEquals("should be zero documents", writer.docCount(), 0);
- addDoc(writer);
- writer.close();
+ // now open reader:
+ IndexReader reader = IndexReader.open(dir);
+ assertEquals("should be one document", reader.numDocs(), 1);
+
+ // now open index for create:
+ writer = new IndexWriter(dir, new WhitespaceAnalyzer(), true);
+ assertEquals("should be zero documents", writer.docCount(), 0);
+ addDoc(writer);
+ writer.close();
- assertEquals("should be one document", reader.numDocs(), 1);
- IndexReader reader2 = IndexReader.open(dir);
- assertEquals("should be one document", reader2.numDocs(), 1);
- reader.close();
- reader2.close();
- rmDir(indexDir);
+ assertEquals("should be one document", reader.numDocs(), 1);
+ IndexReader reader2 = IndexReader.open(dir);
+ assertEquals("should be one document", reader2.numDocs(), 1);
+ reader.close();
+ reader2.close();
+ } finally {
+ rmDir(indexDir);
+ }
+ }
+
+
+ // Same test as above, but use IndexWriter constructor
+ // that takes File:
+ public void testCreateWithReader2() throws IOException {
+ String tempDir = System.getProperty("java.io.tmpdir");
+ if (tempDir == null)
+ throw new IOException("java.io.tmpdir undefined, cannot run test");
+ File indexDir = new File(tempDir, "lucenetestindexwriter");
+ try {
+ // add one document & close writer
+ IndexWriter writer = new IndexWriter(indexDir, new WhitespaceAnalyzer(), true);
+ addDoc(writer);
+ writer.close();
+
+ // now open reader:
+ IndexReader reader = IndexReader.open(indexDir);
+ assertEquals("should be one document", reader.numDocs(), 1);
+
+ // now open index for create:
+ writer = new IndexWriter(indexDir, new WhitespaceAnalyzer(), true);
+ assertEquals("should be zero documents", writer.docCount(), 0);
+ addDoc(writer);
+ writer.close();
+
+ assertEquals("should be one document", reader.numDocs(), 1);
+ IndexReader reader2 = IndexReader.open(indexDir);
+ assertEquals("should be one document", reader2.numDocs(), 1);
+ reader.close();
+ reader2.close();
+ } finally {
+ rmDir(indexDir);
+ }
+ }
+
+ // Same test as above, but use IndexWriter constructor
+ // that takes String:
+ public void testCreateWithReader3() throws IOException {
+ String tempDir = System.getProperty("tempDir");
+ if (tempDir == null)
+ throw new IOException("java.io.tmpdir undefined, cannot run test");
+
+ String dirName = tempDir + "/lucenetestindexwriter";
+ try {
+
+ // add one document & close writer
+ IndexWriter writer = new IndexWriter(dirName, new WhitespaceAnalyzer(), true);
+ addDoc(writer);
+ writer.close();
+
+ // now open reader:
+ IndexReader reader = IndexReader.open(dirName);
+ assertEquals("should be one document", reader.numDocs(), 1);
+
+ // now open index for create:
+ writer = new IndexWriter(dirName, new WhitespaceAnalyzer(), true);
+ assertEquals("should be zero documents", writer.docCount(), 0);
+ addDoc(writer);
+ writer.close();
+
+ assertEquals("should be one document", reader.numDocs(), 1);
+ IndexReader reader2 = IndexReader.open(dirName);
+ assertEquals("should be one document", reader2.numDocs(), 1);
+ reader.close();
+ reader2.close();
+ } finally {
+ rmDir(new File(dirName));
+ }
}
// Simulate a writer that crashed while writing segments
@@ -619,8 +692,10 @@
private void rmDir(File dir) {
File[] files = dir.listFiles();
- for (int i = 0; i < files.length; i++) {
+ if (files != null) {
+ for (int i = 0; i < files.length; i++) {
files[i].delete();
+ }
}
dir.delete();
}
Re: svn commit: r488640 - in /lucene/java/trunk: ./ contrib/spellchecker/src/java/org/apache/lucene/search/spell/
src/java/org/apache/lucene/index/ src/java/org/apache/lucene/store/ src/test/org/apache/lucene/index/
Posted by Michael McCandless <lu...@mikemccandless.com>.
Yonik Seeley wrote:
> On 12/19/06, mikemccand@apache.org <mi...@apache.org> wrote:
>> LUCENE-129: fix finalizers to always call super.finalize
>
> Michael, do you have any opinion on if the finalizer on FSIndexOutput
> should be kept?
> LUCENE-750 removes it...
OK I just added comment in LUCENE-750 (short answer is I don't think
we need to keep that finalizer).
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: svn commit: r488640 - in /lucene/java/trunk: ./ contrib/spellchecker/src/java/org/apache/lucene/search/spell/ src/java/org/apache/lucene/index/ src/java/org/apache/lucene/store/ src/test/org/apache/lucene/index/
Posted by Yonik Seeley <yo...@apache.org>.
On 12/19/06, mikemccand@apache.org <mi...@apache.org> wrote:
> LUCENE-129: fix finalizers to always call super.finalize
Michael, do you have any opinion on if the finalizer on FSIndexOutput
should be kept?
LUCENE-750 removes it...
-Yonik
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: svn commit: r488640 - in /lucene/java/trunk: ./ contrib/spellchecker/src/java/org/apache/lucene/search/spell/
src/java/org/apache/lucene/index/ src/java/org/apache/lucene/store/ src/test/org/apache/lucene/index/
Posted by Michael McCandless <lu...@mikemccandless.com>.
Doug Cutting wrote:
> mikemccand@apache.org wrote:
>> LUCENE-748: add javadoc around semantics of Exception during
>> IndexWriter.close()
>> LUCENE-129: fix finalizers to always call super.finalize
>> LUCENE-301: add new constructors IndexWriter({String,File,Directory},
>> Analyzer) that create index if it's not already there, else append
>> LUCENE-701: found two cases of "open IndexWriter for create while
>> reader is open, on Windows" that I didn't properly fix; added new test
>> cases
>> LUCENE-702: corrected some small javadoc issues
>
> It's best to only address one issue per commit, when possible. That way
> it's much easier to, e.g., back out a buggy fix or merge a fix into
> another branch.
>
> But kudos for putting the bug ID in all related commit messages. That
> makes it easy to find the relevant revisions in Jira, so that fixes can
> be backed out, merged, etc. without having to search mail archives or
> subversion log entries. It's best if every non-trivial commit has a
> well-formed bug ID somewhere in its commit message.
>
> In summary, the ideal is a 1-to-1 mapping from commits to Jira issues.
OK, sorry. I will do that (1 issue per commit) from now on. Thanks.
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: svn commit: r488640 - in /lucene/java/trunk: ./ contrib/spellchecker/src/java/org/apache/lucene/search/spell/
src/java/org/apache/lucene/index/ src/java/org/apache/lucene/store/ src/test/org/apache/lucene/index/
Posted by Doug Cutting <cu...@apache.org>.
mikemccand@apache.org wrote:
> LUCENE-748: add javadoc around semantics of Exception during IndexWriter.close()
> LUCENE-129: fix finalizers to always call super.finalize
> LUCENE-301: add new constructors IndexWriter({String,File,Directory}, Analyzer) that create index if it's not already there, else append
> LUCENE-701: found two cases of "open IndexWriter for create while reader is open, on Windows" that I didn't properly fix; added new test cases
> LUCENE-702: corrected some small javadoc issues
It's best to only address one issue per commit, when possible. That way
it's much easier to, e.g., back out a buggy fix or merge a fix into
another branch.
But kudos for putting the bug ID in all related commit messages. That
makes it easy to find the relevant revisions in Jira, so that fixes can
be backed out, merged, etc. without having to search mail archives or
subversion log entries. It's best if every non-trivial commit has a
well-formed bug ID somewhere in its commit message.
In summary, the ideal is a 1-to-1 mapping from commits to Jira issues.
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org