You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/04/09 20:30:20 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3244: [STORM-3600] Add caching in Cluster.calculateSharedOffHeapNodeMemory

Ethanlm commented on a change in pull request #3244: [STORM-3600] Add caching in Cluster.calculateSharedOffHeapNodeMemory
URL: https://github.com/apache/storm/pull/3244#discussion_r406446966
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java
 ##########
 @@ -749,12 +792,16 @@ private double calculateSharedOffHeapNodeMemory(
      */
     public void freeSlot(WorkerSlot slot) {
         // remove the slot from the existing assignments
+        String nodeId = slot.getNodeId();
 
 Review comment:
   Since this is added, Line 808 can be updated to use `nodeId` instead of `slot.getNodeId()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services