You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/24 21:30:52 UTC

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4616: Add logs to api removeVpnUser

GutoVeronezi commented on a change in pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#discussion_r600887603



##########
File path: server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
##########
@@ -419,7 +419,9 @@ public VpnUser doInTransaction(TransactionStatus status) {
     public boolean removeVpnUser(long vpnOwnerId, String username, Account caller) {
         final VpnUserVO user = _vpnUsersDao.findByAccountAndUsername(vpnOwnerId, username);
         if (user == null) {
-            throw new InvalidParameterValueException("Could not find vpn user " + username);
+            String errorMessage = String.format("Could not find VPN user=[%s]. VPN owner id=[%s]", username, vpnOwnerId);
+            s_logger.debug(errorMessage);

Review comment:
       Or we could update `log4j` to version 2. :grin:  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org