[GitHub] sijie commented on a change in pull request #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments
URL: https://github.com/apache/bookkeeper/pull/1085#discussion_r164838192
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerChecker.java
 ##########
 @@ -195,10 +199,45 @@ private void verifyLedgerFragment(LedgerFragment fragment,
             bookieClient.readEntry(bookie, fragment
                     .getLedgerId(), firstStored, manycb, null);
         } else {
-            ReadManyEntriesCallback manycb = new ReadManyEntriesCallback(2,
+            assert lastStored > firstStored;
 
 Review comment:
   let's not use `assert`. if `lastStored <= firstStored`, let's fail the callback `cb`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services