You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/11 00:54:13 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
dongjoon-hyun opened a new pull request #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870
### What changes were proposed in this pull request?
This PR aims to bring the bug fixes from the latest netty-all.
### Why are the changes needed?
- 4.1.47.Final: https://github.com/netty/netty/milestone/222?closed=1 (15 patches or issues)
- 4.1.46.Final: https://github.com/netty/netty/milestone/221?closed=1 (80 patches or issues)
- 4.1.45.Final: https://github.com/netty/netty/milestone/220?closed=1 (23 patches or issues)
- 4.1.44.Final: https://github.com/netty/netty/milestone/218?closed=1 (113 patches or issues)
- 4.1.43.Final: https://github.com/netty/netty/milestone/217?closed=1 (63 patches or issues)
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Pass the Jenkins with the existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yhuai commented on issue #27870: [SPARK-31095][BUILD][2.4]
Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
yhuai commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597400255
What is the bug you want to patch? I think it is risky to pull in those changes in without explaining any specific reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597401188
`CVE-2019-20445` is reported at https://issues.apache.org/jira/browse/SPARK-31095 by the author.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597428641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119640/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597391046
**[Test build #119640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119640/testReport)** for PR 27870 at commit [`50b377d`](https://github.com/apache/spark/commit/50b377db1ea7e14bc5b0f094929f5b620710902c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597391313
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24371/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597391313
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24371/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597404520
Also, in Netty-all `4.1.39 - 4.1.45`, there are other fixes like
- https://github.com/netty/netty/issues/10017 `java.security.AccessControlException: access denied ("java.io.FilePermission" "/etc/os-release" "read"`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597428635
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597428635
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597391310
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597391046
**[Test build #119640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119640/testReport)** for PR 27870 at commit [`50b377d`](https://github.com/apache/spark/commit/50b377db1ea7e14bc5b0f094929f5b620710902c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597428338
**[Test build #119640 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119640/testReport)** for PR 27870 at commit [`50b377d`](https://github.com/apache/spark/commit/50b377db1ea7e14bc5b0f094929f5b620710902c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597797432
Hi, @srowen . Could you review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597391310
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597699669
Ping, @yhuai . Do you have still have a concern on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597428641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119640/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27870:
[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27870: [SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final
URL: https://github.com/apache/spark/pull/27870#issuecomment-597806123
Thank you, @srowen ! Merged to `branch-2.4`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org