[GitHub] [unomi] sergehuber commented on issue #144: Apache unomi 296

[GitBox <gi...@apache.org>]

sergehuber commented on issue #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144#issuecomment-614604615
 
 
   Thanks for the changes, I would still like to integrate the frontend-maven-plugin to avoid copying all the Javascript files into the project. Are you familiar with it ? You can simply use a package.json file at the root of your project and then have it executed like this:
   
               <plugin>
                   <groupId>com.github.eirslett</groupId>
                   <artifactId>frontend-maven-plugin</artifactId>
                   <version>1.8.0</version>
                   <executions>
                       <execution>
                           <id>npm install node and yarn</id>
                           <phase>generate-resources</phase>
                           <goals>
                               <goal>install-node-and-yarn</goal>
                           </goals>
                           <configuration>
                               <nodeVersion>v11.11.0</nodeVersion>
                               <yarnVersion>v1.19.1</yarnVersion>
                           </configuration>
                       </execution>
                       <execution>
                           <id>yarn install</id>
                           <phase>generate-resources</phase>
                           <goals>
                               <goal>yarn</goal>
                           </goals>
                       </execution>
                       <execution>
                           <id>yarn post-install</id>
                           <phase>generate-resources</phase>
                           <goals>
                               <goal>yarn</goal>
                           </goals>
                           <configuration>
                               <arguments>${yarn.arguments}</arguments>
                           </configuration>
                       </execution>
                   </executions>
               </plugin>
   
   This way you could use yarn add graphql-playground-react and set it up as needed. What do you think ? 
   
   Also did you see that GraphQL Playground and GraphiQL will be merging. It doesn't change anything right now but it might be something we want to stay on top of. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services