You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Roland Weber (JIRA)" <ji...@apache.org> on 2008/01/05 16:46:34 UTC

[jira] Created: (HTTPCORE-136) HttpParams has no removeParameter

HttpParams has no removeParameter
---------------------------------

                 Key: HTTPCORE-136
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-136
             Project: HttpComponents Core
          Issue Type: Improvement
          Components: HttpCore
    Affects Versions: 4.0-alpha6
            Reporter: Roland Weber
            Priority: Minor
             Fix For: 4.0-beta1


Interface HttpParams has methods to set and query parameter values, but not to remove one.
A set operation with null value could be used, but the semantic for hierarchy lookup of a parameter
set to null may be different than for a parameter not set at all.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Resolved: (HTTPCORE-136) HttpParams has no removeParameter

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCORE-136.
----------------------------------------

    Resolution: Fixed

Makes sense to me. Many thanks for contributing the patch, Andrea. Patch checked in

Oleg

> HttpParams has no removeParameter
> ---------------------------------
>
>                 Key: HTTPCORE-136
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-136
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.0-alpha6
>            Reporter: Roland Weber
>            Priority: Minor
>             Fix For: 4.0-beta1
>
>         Attachments: fix_136.patch
>
>
> Interface HttpParams has methods to set and query parameter values, but not to remove one.
> A set operation with null value could be used, but the semantic for hierarchy lookup of a parameter
> set to null may be different than for a parameter not set at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCORE-136) HttpParams has no removeParameter

Posted by "Andrea Selva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrea Selva updated HTTPCORE-136:
----------------------------------

    Attachment: fix_136.patch

Hi Oleg,
I think this could be an usable patch. Only one note,in removeParameter method  i didn't used the follow code:
       if (this.parameters.remove(name) != null) {
            return true;
        } else {
            return false;
        }

because i lost the case where the name key has a null value.
Best regards
 Andrea


> HttpParams has no removeParameter
> ---------------------------------
>
>                 Key: HTTPCORE-136
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-136
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.0-alpha6
>            Reporter: Roland Weber
>            Priority: Minor
>             Fix For: 4.0-beta1
>
>         Attachments: fix_136.patch
>
>
> Interface HttpParams has methods to set and query parameter values, but not to remove one.
> A set operation with null value could be used, but the semantic for hierarchy lookup of a parameter
> set to null may be different than for a parameter not set at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org