[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5036: net: Implement getifaddrs and freeifaddrs

[GitBox <gi...@apache.org>]

pkarashchenko commented on a change in pull request #5036:
URL: https://github.com/apache/incubator-nuttx/pull/5036#discussion_r771997906



##########
File path: libs/libc/net/lib_getifaddrs.c
##########
@@ -0,0 +1,275 @@
+/****************************************************************************
+ * libs/libc/net/lib_getifaddrs.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <errno.h>
+#include <ifaddrs.h>
+#include <net/if.h>
+#include <sys/ioctl.h>
+#include <string.h>
+#include <unistd.h>
+
+#include <nuttx/net/netconfig.h>
+
+#include "libc.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#undef  broadaddr
+#define broadaddr dstaddr
+
+/****************************************************************************
+ * Private Type Definitions
+ ****************************************************************************/
+
+struct myifaddrs
+{
+  struct ifaddrs          addrs;
+  char                    name[IF_NAMESIZE];
+  struct sockaddr_storage addr;
+  struct sockaddr_storage netmask;
+  struct sockaddr_storage dstaddr;
+  struct sockaddr         hwaddr;
+};
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: getifaddrs
+ *
+ * Description:
+ *   The getifaddrs() function returns a link list of ifaddrs structures,
+ *   each containing information about one of the network interfaces on the
+ *   local system. The ifaddrs structure contains at least the following
+ *   entries:
+ *        struct ifaddrs  *ifa_next;
+ *        char            *ifa_name;
+ *        unsigned int     ifa_flags;
+ *        struct sockaddr *ifa_addr;
+ *        struct sockaddr *ifa_netmask;
+ *        struct sockaddr *ifa_dstaddr;
+ *        void            *ifa_data;
+ *  The ifa_next field contains a pointer to the next structure on
+ *  the list, or NULL if this is the last item of the list.
+ *
+ *  The ifa_name points to the null-terminated interface name.
+ *
+ *  The ifa_flags field contains the interface flags, as returned by
+ *  the SIOCGIFFLAGS ioctl(2) operation (see netdevice(7) for a list
+ *  of these flags).
+ *
+ *  The ifa_addr field points to a structure containing the interface
+ *  address.  (The sa_family subfield should be consulted to
+ *  determine the format of the address structure.)  This field may
+ *  contain a null pointer.
+ *
+ *  The ifa_netmask field points to a structure containing the
+ *  netmask associated with ifa_addr, if applicable for the address
+ *  family.  This field may contain a null pointer.
+ *
+ *  Depending on whether the bit IFF_BROADCAST or IFF_POINTOPOINT is
+ *  set in ifa_flags (only one can be set at a time), either
+ *  ifa_broadaddr will contain the broadcast address associated with
+ *  ifa_addr (if applicable for the address family) or ifa_dstaddr
+ *  will contain the destination address of the point-to-point
+ *  interface.
+ *
+ *  The ifa_data field points to a buffer containing address-family-
+ *  specific data; this field may be NULL if there is no such data
+ *  for this interface.
+ *
+ * Input Parameters:
+ *   None
+ *
+ * Returned Value:
+ *   On success, getifaddrs() returns pointer to the link list; on error,
+ *   NULL is returned, and errno is set to indicate the error.
+ *
+ ****************************************************************************/
+
+int getifaddrs(FAR struct ifaddrs **addrs)
+{
+  FAR struct myifaddrs *myaddrs = NULL;
+  int sockfd;
+  int i;
+
+  if (addrs == NULL)
+    {
+      set_errno(EINVAL);
+      return ERROR;
+    }
+
+  sockfd = socket(NET_SOCK_FAMILY, NET_SOCK_TYPE, NET_SOCK_PROTOCOL);
+  if (sockfd < 0)
+    {
+      return sockfd;
+    }
+
+  for (i = 1; i <= MAX_IFINDEX; i++)
+    {
+      unsigned int flags;
+      struct lifreq req =
+      {
+      };
+
+      req.lifr_ifindex = i;

Review comment:
       ```suggestion
         struct lifreq req =
         {
           req.lifr_ifindex = i
         };
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org