You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/10 21:41:59 UTC
[jira] [Commented] (BEAM-147) Introduce an easy API for pipeline
metrics
[ https://issues.apache.org/jira/browse/BEAM-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816272#comment-15816272 ]
ASF GitHub Bot commented on BEAM-147:
-------------------------------------
GitHub user pabloem opened a pull request:
https://github.com/apache/beam/pull/1761
[BEAM-147] Adding proto buff matchers for dataflow client
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Adding these matchers to test changes to dataflow client - service communication in metrics.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pabloem/incubator-beam proto-matchers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1761
----
commit e8be8fa28a1095c8e881a1d48bb4a0265ab42ed4
Author: Pablo <pa...@google.com>
Date: 2017-01-10T21:38:48Z
Adding proto buff matchers for dataflow client
----
> Introduce an easy API for pipeline metrics
> ------------------------------------------
>
> Key: BEAM-147
> URL: https://issues.apache.org/jira/browse/BEAM-147
> Project: Beam
> Issue Type: Bug
> Components: beam-model, sdk-java-core, sdk-py
> Reporter: Robert Bradshaw
> Assignee: Ben Chambers
>
> The existing Aggregators are confusing both because of their name and because they serve multiple purposes.
> Previous discussions around Aggregators/metrics/etc.
> See discussion at http://mail-archives.apache.org/mod_mbox/incubator-beam-user/201603.mbox/browser and http://mail-archives.apache.org/mod_mbox/incubator-beam-dev/201603.mbox/browser . Exact name still being bikeshedded.
> Design document: http://s.apache.org/beam-metrics-api
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)