[GitHub] [hadoop] steveloughran commented on a change in pull request #2148: HADOOP-17131 Moving listing to use operation callback

[GitBox <gi...@apache.org>]

steveloughran commented on a change in pull request #2148:
URL: https://github.com/apache/hadoop/pull/2148#discussion_r463954321



##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Listing.java
##########
@@ -68,15 +68,21 @@
  * Place for the S3A listing classes; keeps all the small classes under control.
  */
 @InterfaceAudience.Private
-public class Listing extends AbstractStoreOperation {
+public class Listing {

Review comment:
       1. I'd keep it as a subclass of AbstractStoreOperation.
   2. we may want to declare it as Closeable, and in tests and S3AFS call close()/closeQuietly() on it. Gives us the option of doing more with it later
   
   What I don't want -and which you have done in this commit, is add the new list commands into the OperationCallbacks interface




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org