You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/09/10 09:47:05 UTC

[PR] Fix sink user pipe visibility and mask credentials in SHOW CREATE PIPE [iotdb]

Caideyipi opened a new pull request, #18617:
URL: https://github.com/apache/iotdb/pull/18617

   ## Description
   
   ### Pipe visibility
   
   - Fix write-back sink user visibility checks to read connector/sink authentication keys instead of extractor/source keys.
   - Allow associated sink users to query the pipe through SHOW PIPES and SHOW CREATE PIPE.
   
   ### Credential masking
   
   - Mask sensitive pipe attribute values in SHOW CREATE PIPE with the shared PipeParameters.ValueHider key rules.
   - Cover source/sink passwords, extractor/connector aliases, and SSL credential keys.
   
   ### Tests
   
   - Update ShowCreateTaskTest to verify explicit and alias-prefixed credentials are masked.
   - Extend IoTDBPipePermissionIT to verify sink-user visibility and masked SHOW CREATE PIPE output.
   - Passed targeted ShowCreateTaskTest (9 tests).
   - Passed Spotless for ConfigNode, DataNode, and integration-test.
   - Passed Checkstyle for ConfigNode and DataNode. Integration-test standalone Checkstyle is blocked by its existing unresolved baseDir configuration.
   - The targeted integration-test reactor compiled the changed production modules, but could not reach the IT on this Windows host because existing generated-file RAT/dependency-analysis failures and JVM virtual-memory exhaustion interrupted the build.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added or updated unit tests.
   - [x] added integration tests.
   
   <hr>
   
   ##### Key changed/added classes
   
   - PipeTableResp
   - ShowCreatePipeTask
   - ShowCreateTaskTest
   - IoTDBPipePermissionIT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix sink user pipe visibility and mask credentials in SHOW CREATE PIPE [iotdb]

Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18617:
URL: https://github.com/apache/iotdb/pull/18617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org