You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "MrPowers (via GitHub)" <gi...@apache.org> on 2025/01/09 14:10:47 UTC
[PR] add contributing file [sedona]
MrPowers opened a new pull request, #1750:
URL: https://github.com/apache/sedona/pull/1750
## Did you read the Contributor Guide?
- Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
## Is this PR related to a JIRA ticket?
Fixes #1728.
## What changes were proposed in this PR?
Adds a CONTRIBUTING file, as recommended by GitHub.
## How was this patch tested?
N/A.
## Did this PR include necessary documentation updates?
- No, this PR does not affect any public API so no need to change the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] add contributing file [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1750:
URL: https://github.com/apache/sedona/pull/1750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add contributing file [sedona]
Posted by "MrPowers (via GitHub)" <gi...@apache.org>.
MrPowers commented on PR #1750:
URL: https://github.com/apache/sedona/pull/1750#issuecomment-2592793653
@james-willis - I updated that section, let me know if it looks better now. Thanks for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add contributing file [sedona]
Posted by "james-willis (via GitHub)" <gi...@apache.org>.
james-willis commented on PR #1750:
URL: https://github.com/apache/sedona/pull/1750#issuecomment-2581562627
Are you duplicating the contents here? https://sedona.apache.org/latest/community/contact/
Some of the contents contradict what is present there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add contributing file [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #1750:
URL: https://github.com/apache/sedona/pull/1750#issuecomment-2581009845
@MrPowers can you run `pre-commit run --all-files` locally to fix the lint issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add contributing file [sedona]
Posted by "MrPowers (via GitHub)" <gi...@apache.org>.
MrPowers commented on PR #1750:
URL: https://github.com/apache/sedona/pull/1750#issuecomment-2583041517
@jiayuasu - I ran that command and pushed up the fix, thank you!
@james-willis - I tried my best to make them consistent, but perhaps need to make some tweaks. I just took another look and nothing jumped out. Anything in particular you think I should update? Thanks for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add contributing file [sedona]
Posted by "james-willis (via GitHub)" <gi...@apache.org>.
james-willis commented on PR #1750:
URL: https://github.com/apache/sedona/pull/1750#issuecomment-2591416751
I think im objecting to the "Did you create a PR to fix a bug?" section. I think you need to just fill out the template, not write in the description which issues youre addressing. Issue ID will go in the title in brackets at the start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org