[GitHub] [incubator-hudi] vinothchandar commented on issue #1073: [WIP] [HUDI-377] Adding Delete() support to DeltaStreamer

[GitBox <gi...@apache.org>]

vinothchandar commented on issue #1073: [WIP] [HUDI-377] Adding Delete() support to DeltaStreamer
URL: https://github.com/apache/incubator-hudi/pull/1073#issuecomment-562872607
 
 
   >Option a. Introduce a new config for delete marker key. Hoodie internal classes will assume this field as delete marker (all the way to OverwriteWithLatestAvroPayload)
   
   I think this is good enough.. First pass we need not even make this configurable i.e force the user to name the delete marker `_hoodie_delete_marker` and including it in the source schema is the user's responsibility.. (If user does not do this, there is no such field and our check simply moves on)... 
   
   We should not treat the _hoodie_delete_marker field like we treat the other _hoodie* columns we add.. They serve completely different purposes..  I'd punt on even making it configurable for now.. We can file a JIRA for later, and iterate based on user feedback.. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services