[GitHub] [hudi] xicm commented on a diff in pull request #6715: [HUDI-3983] ClassNotFoundException when using hudi-spark-bundle to write table with hbase index

[GitBox <gi...@apache.org>]

xicm commented on code in PR #6715:
URL: https://github.com/apache/hudi/pull/6715#discussion_r973922086


##########
hudi-common/src/main/resources/hbase-site.xml:
##########
@@ -1699,13 +1699,16 @@ possible configurations would overwhelm and obscure the important.
       Implementation of the status publication with a multicast message.
     </description>
   </property>
-  <property>
-    <name>hbase.status.listener.class</name>
-    <value>org.apache.hadoop.hbase.client.ClusterStatusListener$MulticastListener</value>
-    <description>
-      Implementation of the status listener with a multicast message.
-    </description>
-  </property>
+
+  <!-- Hbase related classes used in hudi bundle packages are in shaded pattern,
+  this config can cause ClassNotFoundException -->
+  <!--<property>-->
+  <!--  <name>hbase.status.listener.class</name>-->
+  <!--  <value>org.apache.hadoop.hbase.client.ClusterStatusListener$MulticastListener</value>-->
+  <!--  <description>-->
+  <!--    Implementation of the status listener with a multicast message.-->
+  <!--  </description>-->
+  <!--</property>-->

Review Comment:
   Initialization of the listener in Hbase
   
   https://github.com/apache/hbase/blob/c49f7f63fca144765bf7c2da41791769286dfccc/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L302-L305
   
   https://github.com/apache/hbase/blob/c49f7f63fca144765bf7c2da41791769286dfccc/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterStatusListener.java#L72-L73



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org