You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/17 12:08:00 UTC
[jira] [Commented] (FLINK-7854) Reject lateral table outer joins
with predicates in SQL
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207549#comment-16207549 ]
ASF GitHub Bot commented on FLINK-7854:
---------------------------------------
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4846
[FLINK-7854] [table] Reject lateral table outer joins with predicates in SQL
## What is the purpose of the change
Due to CALCITE-2004, this PR aims to temporarily restrict the predicates for left outer join against the lateral table to be literal `TRUE`.
## Brief change log
- Override the `validateJoin()` method in `FlinkCalciteSqlValidator` to check the join conditions.
- Update the tests.
- Refine the documents.
## Verifying this change
This change is already covered by existing tests `CorrelateTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (docs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xccui/flink FLINK-7854
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4846.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4846
----
commit d63bfd569921180fae8f3bee6dd564e47e34f7ff
Author: Xingcan Cui <xi...@gmail.com>
Date: 2017-10-16T08:49:14Z
[FLINK-7854] [table] Reject lateral table outer joins with predicates in SQL
----
> Reject lateral table outer joins with predicates in SQL
> -------------------------------------------------------
>
> Key: FLINK-7854
> URL: https://issues.apache.org/jira/browse/FLINK-7854
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Xingcan Cui
> Assignee: Xingcan Cui
> Priority: Blocker
> Fix For: 1.4.0
>
>
> Due to CALCITE-2004, lateral table outer joins can not be normally executed. We should cover it up by rejecting join predicates temporarily, until the issue is fixed in Calcite.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)