[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6604: emit metric for upsert table memory usage

[GitBox <gi...@apache.org>]

deemoliu commented on a change in pull request #6604:
URL: https://github.com/apache/incubator-pinot/pull/6604#discussion_r582238968



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/PartitionUpsertMetadataManager.java
##########
@@ -22,6 +22,7 @@
 import java.util.Iterator;
 import java.util.concurrent.ConcurrentHashMap;
 import javax.annotation.concurrent.ThreadSafe;
+import jdk.nashorn.internal.ir.debug.ObjectSizeCalculator;

Review comment:
       Hi @fx19880617   I found ObjectSizeCalculator is not supported JDK11. 
   https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-May/011770.html
   
   I also looked into calculating the bytes used by metadata manually, but it's not optimal since it required extra storage.
   Do you have any suggestions or recommendations, is there any similar metrics emitted by Pinot?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org