You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hou Song (Created) (JIRA)" <ji...@apache.org> on 2011/10/13 04:49:12 UTC

[jira] [Created] (HDFS-2444) A bug in unit test: TestDFSShell.testText()

A bug in unit test: TestDFSShell.testText()
-------------------------------------------

                 Key: HDFS-2444
                 URL: https://issues.apache.org/jira/browse/HDFS-2444
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: test
    Affects Versions: 0.21.0
            Reporter: Hou Song


testText() writes the same random String into a ByteArray in memory and a GZIPOutputStream in DFS. After closing GZIPOutputStream, it reads it back using shell command -text, and compares it against the ByteArray. However, before comparing, the shell output and the ByteArray are both reset, making the comparison useless. 
What's more, after closing the GZIPOutputStream, DFS is unable to find the file, and the -text command failed to read, giving no output. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-2444) A bug in unit test: TestDFSShell.testText()

Posted by "Hou Song (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hou Song updated HDFS-2444:
---------------------------

    Attachment: HDFS-2444.patch

A simple fix: just remove, and test also succeeds. 
                
> A bug in unit test: TestDFSShell.testText()
> -------------------------------------------
>
>                 Key: HDFS-2444
>                 URL: https://issues.apache.org/jira/browse/HDFS-2444
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.21.0
>            Reporter: Hou Song
>         Attachments: HDFS-2444.patch
>
>
> testText() writes the same random String into a ByteArray in memory and a GZIPOutputStream in DFS. After closing GZIPOutputStream, it reads it back using shell command -text, and compares it against the ByteArray. However, before comparing, the shell output and the ByteArray are both reset, making the comparison useless. 
> What's more, after closing the GZIPOutputStream, DFS is unable to find the file, and the -text command failed to read, giving no output. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-2444) A bug in unit test: TestDFSShell.testText()

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151253#comment-13151253 ] 

Hadoop QA commented on HDFS-2444:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501580/HDFS-2444.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.security.TestDelegationToken
                  org.apache.hadoop.hdfs.tools.TestGetGroups
                  org.apache.hadoop.hdfs.TestDfsOverAvroRpc
                  org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
                  org.apache.hadoop.hdfs.TestLeaseRecovery2
                  org.apache.hadoop.hdfs.TestDistributedFileSystem
                  org.apache.hadoop.hdfs.TestPread
                  org.apache.hadoop.hdfs.TestBlocksScheduledCounter

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1561//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1561//console

This message is automatically generated.
                
> A bug in unit test: TestDFSShell.testText()
> -------------------------------------------
>
>                 Key: HDFS-2444
>                 URL: https://issues.apache.org/jira/browse/HDFS-2444
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.21.0, 0.23.0
>            Reporter: Hou Song
>         Attachments: HDFS-2444.patch
>
>
> testText() writes the same random String into a ByteArray in memory and a GZIPOutputStream in DFS. After closing GZIPOutputStream, it reads it back using shell command -text, and compares it against the ByteArray. However, before comparing, the shell output and the ByteArray are both reset, making the comparison useless. 
> What's more, after closing the GZIPOutputStream, DFS is unable to find the file, and the -text command failed to read, giving no output. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-2444) A bug in unit test: TestDFSShell.testText()

Posted by "Hou Song (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hou Song updated HDFS-2444:
---------------------------

    Affects Version/s: 0.23.0
               Status: Patch Available  (was: Open)
    
> A bug in unit test: TestDFSShell.testText()
> -------------------------------------------
>
>                 Key: HDFS-2444
>                 URL: https://issues.apache.org/jira/browse/HDFS-2444
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0, 0.21.0
>            Reporter: Hou Song
>         Attachments: HDFS-2444.patch
>
>
> testText() writes the same random String into a ByteArray in memory and a GZIPOutputStream in DFS. After closing GZIPOutputStream, it reads it back using shell command -text, and compares it against the ByteArray. However, before comparing, the shell output and the ByteArray are both reset, making the comparison useless. 
> What's more, after closing the GZIPOutputStream, DFS is unable to find the file, and the -text command failed to read, giving no output. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira