[GitHub] [pulsar] zymap commented on a diff in pull request #17226: [Branch-2.8][improve][broker]Add retry for zk operation on connection loss

[GitBox <gi...@apache.org>]

zymap commented on code in PR #17226:
URL: https://github.com/apache/pulsar/pull/17226#discussion_r952221278


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java:
##########
@@ -120,7 +121,12 @@ public CompletableFuture<Optional<GetResult>> get(String path) {
                             return null;
                         });
                         future.complete(Optional.empty());
-                    } else {
+                    } else if (code == Code.CONNECTIONLOSS) {
+                        // There is the chance that we caused a connection reset by sending or requesting a batch

Review Comment:
   Do we need to log something before retrying? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org