[GitHub] [incubator-superset] nytai commented on a change in pull request #11370: fix: add sort option to filters, sort chart list filter options

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #11370:
URL: https://github.com/apache/incubator-superset/pull/11370#discussion_r509616603



##########
File path: superset-frontend/src/components/ListView/Filters.tsx
##########
@@ -119,6 +121,25 @@ function SelectFilter({
         setSelectedOption(matchingOption);
       }
     }
+
+    // Check whether list should be sorted (alphanumerically, ascending)
+    if (sort) {

Review comment:
       We probably want to add the sorting on the backend. In the case that the results are paginated, this sorting would only be on each page and not across the entire result set. We can likely add another entry [here](https://github.com/preset-io/incubator-superset/blob/master/superset-frontend/src/views/CRUD/utils.tsx#L38) for sorting. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org