Re: [PR] Fixes for several string formats, they are based on static analysis. [jmeter]

["FSchumacher (via GitHub)" <gi...@apache.org>]

FSchumacher commented on code in PR #6306:
URL: https://github.com/apache/jmeter/pull/6306#discussion_r1778229190


##########
src/protocol/tcp/src/main/java/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java:
##########
@@ -504,7 +504,7 @@ private void closeSocket(String socketKey) {
             try {
                 con.close();
             } catch (IOException e) {
-                log.warn("Error closing socket {}", e); //$NON-NLS-1$
+                log.warn("Error closing socket", e); //$NON-NLS-1$

Review Comment:
   Again, I think it is better to keep the short (string version) of the message here.



##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java:
##########
@@ -268,7 +268,7 @@ protected void computeFromPostBody(HTTPSamplerBase sampler,
                         HTTPFileArg [] files = {new HTTPFileArg(out.getPath(),"",contentType)};
                         sampler.setHTTPFiles(files);
                     } catch (IOException e) {
-                        log.warn("Could not create binary file: {}", e);
+                        log.warn("Could not create binary file", e);

Review Comment:
   Do we want the complete stacktrace to be shown here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org